edac_752x needs CONFIG_HOTPLUG
PATCH 1/1 edac_752x needs CONFIG_HOTPLUG
From: Randy Dunlap <[email protected]>
EDAC_752X uses pci_scan_single_device(), which is only available if CONFIG_HOTPLUG is enabled, so limit this driver with HOTPLUG.
--- drivers/edac/Kconfig | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/edac/Kconfig +1 -1
@@ -71,7 +71,7 @@ config EDAC_E7XXX config EDAC_E752X tristate "Intel e752x (e7520, e7525, e7320)" - depends on EDAC_MM_EDAC && PCI && X86 + depends on EDAC_MM_EDAC && PCI && X86 && HOTPLUG help Support for error detection and correction on the Intel E7520, E7525, E7320 server chipsets.
---
Quoted 3 lines · Randy.Dunlap
EDAC_752Xusespci_scan_single_device(), which is only available ifCONFIG_HOTPLUGis enabled
hm. That's not a hotpluggable device, surely?
If not then either a) PCI should be implementing pci_scan_single_device() if !CONFIG_HOTPLUG or b) EDAC shouldn't be using pci_scan_single_device().
Quoted 9 lines · On Mon, 27 Mar 2006 15:40:55 -0800 Andrew Morton wrote:
Quoted 3 lines · Randy.Dunlap
EDAC_752Xusespci_scan_single_device(), which is only available ifCONFIG_HOTPLUGis enabledhm. That's not a hotpluggable device, surely?
If not then either a) PCI should be implementing
pci_scan_single_device()if !CONFIG_HOTPLUG or b) EDAC shouldn't be usingpci_scan_single_device().
or just that one if block should be surrounded by CONFIG_HOTPLUG (done cleanly, of course).
---
~Randy