Skip to contentSkip to conversation

9p: handle sget() failure

PATCH New Eric Van Hensbergen 1 participant 1 message Apr 3, 2006 9P file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 9p: handle sget() failure

Handle a failing sget() in v9fs_get_sb().

---

 fs/9p/vfs_super.c |   13 ++++++++++---
 1 files changed, 10 insertions(+), 3 deletions(-)

fc6530fb690a8a7b2cd9f5581debcf0f7d98074d

fs/9p/vfs_super.c +10 -3
index b0a0ae5..61c599b 100644
@@ -127,12 +127,13 @@ static struct super_block *v9fs_get_sb(s
 
 	if ((newfid = v9fs_session_init(v9ses, dev_name, data)) < 0) {
 		dprintk(DEBUG_ERROR, "problem initiating session\n");
-		kfree(v9ses);
-		return ERR_PTR(newfid);
+		sb = ERR_PTR(newfid);
+		goto out_free_session;
 	}
 
 	sb = sget(fs_type, NULL, v9fs_set_super, v9ses);
-
+	if (IS_ERR(sb))
+		goto out_close_session;
 	v9fs_fill_super(sb, v9ses, flags);
 
 	inode = v9fs_get_inode(sb, S_IFDIR | mode);
@@ -185,6 +186,12 @@ static struct super_block *v9fs_get_sb(s
 
 	return sb;
 
+out_close_session:
+	v9fs_session_close(v9ses);
+out_free_session:
+	kfree(v9ses);
+	return sb;
+
 put_back_sb:
 	/* deactivate_super calls v9fs_kill_super which will frees the rest */
 	up_write(&sb->s_umount);
Signature · 1 line
1.2.GIT