Skip to contentSkip to conversation

s390: invalid check after kzalloc()

PATCH New Martin Schwidefsky 1 participant 1 message Apr 3, 2006 s390

lore
Share & tools
lore
#0 lore raw

PATCH 3/9 s390: invalid check after kzalloc()

From: Peter Oberparleiter <[email protected]>

[patch 3/9] s390: invalid check after kzalloc()

Typo. After the call to kzalloc() for kdb->key_maps the test for NULL checks the wrong variable.

---

 drivers/s390/char/keyboard.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/s390/char/keyboard.c +1 -1
diff -urpN linux-2.6/drivers/s390/char/keyboard.c linux-2.6-patched/drivers/s390/char/keyboard.c
@@ -54,7 +54,7 @@ kbd_alloc(void) {
 	if (!kbd)
 		goto out;
 	kbd->key_maps = kzalloc(sizeof(key_maps), GFP_KERNEL);
-	if (!key_maps)
+	if (!kbd->key_maps)
 		goto out_kbd;
 	for (i = 0; i < ARRAY_SIZE(key_maps); i++) {
 		if (key_maps[i]) {