Skip to contentSkip to conversation

bcm43xx_sysfs.c: strange code

DISCUSSION Adrian Bunk 1 participant 1 message Apr 4, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

The Coverity checker spotted the following strange code:

<-- snip -->

static ssize_t bcm43xx_attr_interfmode_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
...

        err = 0;

        bcm43xx_unlock(bcm, flags);

        return err ? err : count;

}
...
static ssize_t bcm43xx_attr_preamble_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
...

        err = 0;
        bcm43xx_unlock(bcm, flags);

        return err ? err : count;
}

...
static ssize_t bcm43xx_attr_preamble_store(struct device *dev,
struct device_attribute *attr, const char *buf, size_t count)
{
...

        err = 0;
        bcm43xx_unlock(bcm, flags);

        return err ? err : count;
}

...

<-- snip -->

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed