Skip to contentSkip to conversation

drivers/isdn/capi/capiutil.c: unexport capi_message2str

PATCH In review Adrian Bunk 3 participants 3 messages Apr 7, 2006 – Apr 9, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/isdn/capi/capiutil.c: unexport capi_message2str

This patch removes an unused EXPORT_SYMBOL.

drivers/isdn/capi/capiutil.c renamed from drivers/isdn/capi/capiutil.c.old +0 -1
@@ -855,5 +855,4 @@
 EXPORT_SYMBOL(capi_cmsg_header);
 EXPORT_SYMBOL(capi_cmd2str);
 EXPORT_SYMBOL(capi_cmsg2str);
-EXPORT_SYMBOL(capi_message2str);
 EXPORT_SYMBOL(capi_info2str);
#1 lore raw

drivers/isdn/capi/capiutil.c line 858

Quoted 13 lines · Adrian Bunk

This patch removes an unused EXPORT_SYMBOL.

drivers/isdn/capi/capiutil.c renamed from drivers/isdn/capi/capiutil.c.old +0 -1
@@ -855,5 +855,4 @@
 EXPORT_SYMBOL(capi_cmsg_header);
 EXPORT_SYMBOL(capi_cmd2str);
 EXPORT_SYMBOL(capi_cmsg2str);
-EXPORT_SYMBOL(capi_message2str);
 EXPORT_SYMBOL(capi_info2str);

Yes it is currently unused, but part of the CAPI driver SDK for supporting debug messages in capi drivers, so I would tend to let it exported, if here are not strong arguments against exporting it.

Signature · 3 lines
Karsten Keil
SuSE Labs
ISDN development
#2 lore raw
Quoted 5 lines · Karsten Keil
Quoted 4 lines · Adrian Bunk

This patch removes an unused EXPORT_SYMBOL.

Quoted 13 lines

drivers/isdn/capi/capiutil.c line 858

Quoted 9 lines
drivers/isdn/capi/capiutil.c renamed from drivers/isdn/capi/capiutil.c.old +0 -1
@@ -855,5 +855,4 @@
 EXPORT_SYMBOL(capi_cmsg_header);
 EXPORT_SYMBOL(capi_cmd2str);
 EXPORT_SYMBOL(capi_cmsg2str);
-EXPORT_SYMBOL(capi_message2str);
 EXPORT_SYMBOL(capi_info2str);

Yes it is currently unused, but part of the CAPI driver SDK for supporting debug messages in capi drivers, so I would tend to let it exported, if here are not strong arguments against exporting it.

every export takes space in the binary kernel. There's some 900 of these unused ones, totalling to about 100Kb of unused bloat.