Skip to contentSkip to conversation

dvb/bt8xx/bt878.c: don't export static variables

PATCH In review Adrian Bunk 2 participants 2 messages Apr 9, 2006 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dvb/bt8xx/bt878.c: don't export static variables

Static variables mustn't be EXPORT_SYMBOL'ed.

---

 drivers/media/dvb/bt8xx/bt878.c |    2 --
 1 file changed, 2 deletions(-)
drivers/media/dvb/bt8xx/bt878.c renamed from drivers/media/dvb/bt8xx/bt878.c.old +0 -2
@@ -54,26 +54,24 @@
 static unsigned int bt878_verbose = 1;
 static unsigned int bt878_debug;
 
 module_param_named(verbose, bt878_verbose, int, 0444);
 MODULE_PARM_DESC(verbose,
 		 "verbose startup messages, default is 1 (yes)");
 module_param_named(debug, bt878_debug, int, 0644);
 MODULE_PARM_DESC(debug, "Turn on/off debugging, default is 0 (off).");
 
 int bt878_num;
 struct bt878 bt878[BT878_MAX];
 
-EXPORT_SYMBOL(bt878_debug);
-EXPORT_SYMBOL(bt878_verbose);
 EXPORT_SYMBOL(bt878_num);
 EXPORT_SYMBOL(bt878);
 
 #define btwrite(dat,adr)    bmtwrite((dat), (bt->bt878_mem+(adr)))
 #define btread(adr)         bmtread(bt->bt878_mem+(adr))
 
 #define btand(dat,adr)      btwrite((dat) & btread(adr), adr)
 #define btor(dat,adr)       btwrite((dat) | btread(adr), adr)
 #define btaor(dat,mask,adr) btwrite((dat) | ((mask) & btread(adr)), adr)
 
 #if defined(dprintk)
 #undef dprintk
#1 lore raw
Quoted 31 lines · Adrian Bunk

Static variables mustn't be EXPORT_SYMBOL'ed.

---

 drivers/media/dvb/bt8xx/bt878.c |    2 --
 1 file changed, 2 deletions(-)
drivers/media/dvb/bt8xx/bt878.c renamed from drivers/media/dvb/bt8xx/bt878.c.old +0 -2
@@ -54,26 +54,24 @@
 static unsigned int bt878_verbose = 1;
 static unsigned int bt878_debug;
 
 module_param_named(verbose, bt878_verbose, int, 0444);
 MODULE_PARM_DESC(verbose,
 		 "verbose startup messages, default is 1 (yes)");
 module_param_named(debug, bt878_debug, int, 0644);
 MODULE_PARM_DESC(debug, "Turn on/off debugging, default is 0 (off).");
 
 int bt878_num;
 struct bt878 bt878[BT878_MAX];
 
-EXPORT_SYMBOL(bt878_debug);
-EXPORT_SYMBOL(bt878_verbose);
 EXPORT_SYMBOL(bt878_num);
 EXPORT_SYMBOL(bt878);
 
 #define btwrite(dat,adr)    bmtwrite((dat), (bt->bt878_mem+(adr)))

drivers/media/dvb/bt8xx/bt878.c

Quoted 10 lines
drivers/media/dvb/bt8xx/bt878.c renamed from drivers/media/dvb/bt8xx/bt878.c.old +0 -1
 #define btread(adr)         bmtread(bt->bt878_mem+(adr))
 
 #define btand(dat,adr)      btwrite((dat) & btread(adr), adr)
 #define btor(dat,adr)       btwrite((dat) | btread(adr), adr)
 #define btaor(dat,mask,adr) btwrite((dat) | ((mask) & btread(adr)), adr)
 
 #if defined(dprintk)
 #undef dprintk
 
-

Ack'd-by: Manu Abraham <[email protected]>