Skip to contentSkip to conversation

the scheduled unexport of insert_resource

PATCH In review Adrian Bunk 2 participants 2 messages Apr 10, 2006 – Apr 11, 2006 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 the scheduled unexport of insert_resource

This patch contains the scheduled unexport of insert_resource.

Kumar Gala said that some not yet submitted code uses it [1], but since there is after one month still no code submission, and reverting the exporting it again is trivial if it is both submitted and considered acceptable for inclusion this shouldn't be a problem.

[1] http://lkml.org/lkml/2006/4/1/28

---

 Documentation/feature-removal-schedule.txt |    8 --------
 include/linux/ioport.h                     |    2 +-
 kernel/resource.c                          |    2 --
 3 files changed, 1 insertion(+), 11 deletions(-)
Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +0 -8
@@ -72,14 +72,6 @@
 
 ---------------------------
 
-What:	remove EXPORT_SYMBOL(insert_resource)
-When:	April 2006
-Files:	kernel/resource.c
-Why:	No modular usage in the kernel.
-Who:	Adrian Bunk <[email protected]>
-
----------------------------
-
 What:	PCMCIA control ioctl (needed for pcmcia-cs [cardmgr, cardctl])
 When:	November 2005
 Files:	drivers/pcmcia/: pcmcia_ioctl.c
include/linux/ioport.h renamed from include/linux/ioport.h.old +1 -1
@@ -95,7 +95,7 @@
 extern int request_resource(struct resource *root, struct resource *new);
 extern struct resource * ____request_resource(struct resource *root, struct resource *new);
 extern int release_resource(struct resource *new);
-extern __deprecated_for_modules int insert_resource(struct resource *parent, struct resource *new);
+extern int insert_resource(struct resource *parent, struct resource *new);
 extern int allocate_resource(struct resource *root, struct resource *new,
 			     u64 size,
 			     u64 min, u64 max,
kernel/resource.c renamed from kernel/resource.c.old +0 -2
@@ -381,8 +381,6 @@
 	return result;
 }
 
-EXPORT_SYMBOL(insert_resource);
-
 /*
  * Given an existing resource, change its start and size to match the
  * arguments.  Returns -EBUSY if it can't fit.  Existing children of
#1 lore raw

I'm fine with this. I'll deal with getting my bus code out in the future.

- k

Quoted 68 lines · Adrian Bunk

This patch contains the scheduled unexport of insert_resource.

Kumar Gala said that some not yet submitted code uses it [1], but since there is after one month still no code submission, and reverting the exporting it again is trivial if it is both submitted and considered acceptable for inclusion this shouldn't be a problem.

[1] http://lkml.org/lkml/2006/4/1/28

---

 Documentation/feature-removal-schedule.txt |    8 --------
 include/linux/ioport.h                     |    2 +-
 kernel/resource.c                          |    2 --
 3 files changed, 1 insertion(+), 11 deletions(-)

--- linux-2.6.17-rc1-mm2-full/Documentation/feature-removal-
schedule.txt.old 2006-04-10 20:52:23.000000000 +0200
+++ linux-2.6.17-rc1-mm2-full/Documentation/feature-removal-
schedule.txt 2006-04-10 20:52:36.000000000 +0200

Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +0 -9
@@ -72,14 +72,6 @@
 
 ---------------------------
 
-What:	remove EXPORT_SYMBOL(insert_resource)
-When:	April 2006
-Files:	kernel/resource.c
-Why:	No modular usage in the kernel.
-Who:	Adrian Bunk <[email protected]>
-
----------------------------
-
 What:	PCMCIA control ioctl (needed for pcmcia-cs [cardmgr, cardctl])
 When:	November 2005
 Files:	drivers/pcmcia/: pcmcia_ioctl.c
--- linux-2.6.17-rc1-mm2-full/include/linux/ioport.h.old	2006-04-10  

20:52:46.000000000 +0200
+++ linux-2.6.17-rc1-mm2-full/include/linux/ioport.h 2006-04-10
20:52:55.000000000 +0200

(quoted diff) +1 -1
@@ -95,7 +95,7 @@
 extern int request_resource(struct resource *root, struct resource  
 *new);
 extern struct resource * ____request_resource(struct resource  
 *root, struct resource *new);
 extern int release_resource(struct resource *new);
-extern __deprecated_for_modules int insert_resource(struct  
 resource *parent, struct resource *new);
+extern int insert_resource(struct resource *parent, struct  

resource *new);
extern int allocate_resource(struct resource *root, struct
resource *new,

include/linux/ioport.h renamed from include/linux/ioport.h.old +0 -1
 			     u64 size,
 			     u64 min, u64 max,
--- linux-2.6.17-rc1-mm2-full/kernel/resource.c.old	2006-04-10  

20:53:04.000000000 +0200
+++ linux-2.6.17-rc1-mm2-full/kernel/resource.c 2006-04-10
20:53:11.000000000 +0200

kernel/resource.c renamed from kernel/resource.c.old +0 -2
@@ -381,8 +381,6 @@
 	return result;
 }
 
-EXPORT_SYMBOL(insert_resource);
-
 /*
  * Given an existing resource, change its start and size to match the
  * arguments.  Returns -EBUSY if it can't fit.  Existing children of