Binary sysfs blobs
Hi, Greg:
I was reviewing some patches here and noticed (yes, only now noticed) that we have operations on binary blobs in fs/sysfs/bin.c. I thought it wasn't part of the deal for sysfs, with one value per file and so on. I suppose it's too late to debate now, but I have a couple of questions:
- Do you know of any conventions which allow to determine which file is binary? Maybe the name starting with an underscore or something?
- Is there a standing policy that reading from a sysfs file is not altering a state of the corresponding hardware? This is not related to blobs directly, but with people passing structs now, it's tempting to implement some extended protocols. I am concerned of stealing network packets by accident or something.
Greetings,
-- Pete
Quoted 10 lines · Pete Zaitcev
Hi, Greg:
I was reviewing some patches here and noticed (yes, only now noticed) that we have operations on binary blobs in
fs/sysfs/bin.c. I thought it wasn't part of the deal for sysfs, with one value per file and so on. I suppose it's too late to debate now, but I have a couple of questions:- Do you know of any conventions which allow to determine which file is binary? Maybe the name starting with an underscore or something?
AFAIK there isn't any convention. The PCI related files (/sys/bus/pci/devices/...) don't have a particular naming scheme for example.
Quoted 5 lines
- Is there a standing policy that reading from a sysfs file is not altering a state of the corresponding hardware? This is not related to blobs directly, but with people passing structs now, it's
tempting to implement some extended protocols. I am concerned of stealing network packets by accident or something.
Nope, again if you access the PCI files you may end up programming the hardware in some way. There may be other examples of this elsewhere, but I haven't looked.
Jesse
Quoted 9 lines · Pete Zaitcev
Hi, Greg:
I was reviewing some patches here and noticed (yes, only now noticed) that we have operations on binary blobs in
fs/sysfs/bin.c. I thought it wasn't part of the deal for sysfs, with one value per file and so on. I suppose it's too late to debate now, but I have a couple of questions:- Do you know of any conventions which allow to determine which file is binary? Maybe the name starting with an underscore or something?
Hm, no, no convention right now, sorry.
Quoted 5 lines
- Is there a standing policy that reading from a sysfs file is not altering a state of the corresponding hardware? This is not related to blobs directly, but with people passing structs now, it's tempting to implement some extended protocols. I am concerned of stealing network packets by accident or something.
No. Binary sysfs files are for "pass-through" mode only. You are ONLY allowed to use them if you want to read from, or write to, some bit of hardware and not manipulate the data at all. Examples of this is the raw PCI config space, firmware binary blobs and BIOS upgrades.
You should NEVER pass a raw structure through sysfs by using a binary file. If anyone sees anywhere in the current kernel that does this, please let me know and I'll go hit them with a big stick...
And yes, I know the documentation on the conventions for this is seriously lacking. Fixing that is slowly moving up my TODO list...
Hope this helps,
greg k-h
Quoted 4 lines · Greg KH
No. Binary sysfs files are for "pass-through" mode only. You are ONLY allowed to use them if you want to read from, or write to, some bit of hardware and not manipulate the data at all. Examples of this is the raw PCI config space, firmware binary blobs and BIOS upgrades.
I see. Kind of the opposite of what I thought they were, but it makes sense. Thanks.
Quoted 3 lines
You should NEVER pass a raw structure through sysfs by using a binary file. If anyone sees anywhere in the current kernel that does this, please let me know and I'll go hit them with a big stick...
I dunno how raw this is, but chp_measurement_copy_block and chp_measurement_read (in drivers/s390/cio/chsc.c) sure look like passing structures, in 2.6.17-rc1. However, the code does not interpret the structures, so maybe it's raw enough.
-- Pete