Skip to contentSkip to conversation

__group_complete_signal: remove bogus BUG_ON

PATCH New Oleg Nesterov 1 participant 1 message Apr 11, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 __group_complete_signal: remove bogus BUG_ON

Commit e56d090310d7625ecb43a1eeebd479f04affb48b
[PATCH] RCU signal handling

made this BUG_ON() unsafe. This code runs under ->siglock, while switch_exec_pids() takes tasklist_lock.

kernel/signal.c renamed from kernel/signal.c~ +0 -1
@@ -975,7 +975,6 @@ __group_complete_signal(int sig, struct 
 		if (t == NULL)
 			/* restart balancing at this thread */
 			t = p->signal->curr_target = p;
-		BUG_ON(t->tgid != p->tgid);
 
 		while (!wants_signal(sig, t)) {
 			t = next_thread(t);