Skip to contentSkip to conversation

drivers/char/ipmi/ipmi_msghandler.c: make proc_ipmi_root static

PATCH New Adrian Bunk 1 participant 1 message Apr 13, 2006 IPMI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/char/ipmi/ipmi_msghandler.c: make proc_ipmi_root static

This patch makes the needlessly global struct proc_ipmi_root static.

Besides this, it removes an unused #ifdef CONFIG_PROC_FS from include/linux/ipmi.h.

---

BTW: Please add an entry for IPMI to MAINTAINERS.

 drivers/char/ipmi/ipmi_msghandler.c |    3 +--
 include/linux/ipmi.h                |    4 ----
 2 files changed, 1 insertion(+), 6 deletions(-)
include/linux/ipmi.h renamed from include/linux/ipmi.h.old +0 -4
@@ -210,11 +210,7 @@
  */
 #include <linux/list.h>
 #include <linux/module.h>
-
-#ifdef CONFIG_PROC_FS
 #include <linux/proc_fs.h>
-extern struct proc_dir_entry *proc_ipmi_root;
-#endif /* CONFIG_PROC_FS */
 
 /* Opaque type for a IPMI message user.  One of these is needed to
    send and receive messages. */
drivers/char/ipmi/ipmi_msghandler.c renamed from drivers/char/ipmi/ipmi_msghandler.c.old +1 -2
@@ -57,8 +57,7 @@
 static int initialized = 0;
 
 #ifdef CONFIG_PROC_FS
-struct proc_dir_entry *proc_ipmi_root = NULL;
-EXPORT_SYMBOL(proc_ipmi_root);
+static struct proc_dir_entry *proc_ipmi_root = NULL;
 #endif /* CONFIG_PROC_FS */
 
 #define MAX_EVENTS_IN_QUEUE	25