net/irda/irias_object.c: remove unused exports
Subsystems (2)
RFC PATCH 1/1 net/irda/irias_object.c: remove unused exports
This patch removes the following unused EXPORT_SYMBOL's:
- irias_find_attrib
- irias_new_string_value
- irias_new_octseq_value
---
net/irda/irias_object.c | 3 --- 1 file changed, 3 deletions(-)
net/irda/irias_object.c renamed from net/irda/irias_object.c.old +0 -3
@@ -257,7 +257,6 @@/* Unsafe (locking), attrib might change */ return attrib; } -EXPORT_SYMBOL (irias_find_attrib);/* * Function irias_add_attribute (obj, attrib)
@@ -484,7 +483,6 @@return value; } -EXPORT_SYMBOL (irias_new_string_value);/* * Function irias_new_octseq_value (octets, len)
@@ -519,7 +517,6 @@memcpy (value->t.oct_seq, octseq , len);return value; } -EXPORT_SYMBOL (irias_new_octseq_value);struct ias_value *irias_new_missing_value (void ) {
Hi,
You now need to send those patches to :
[email protected]
Personally, I don't see what this patch buy us...
Jean
Quoted 39 lines · Adrian Bunk
This patch removes the following unused EXPORT_SYMBOL's:
-irias_find_attrib
-irias_new_string_value
-irias_new_octseq_valueSigned-off-by Adrian Bunk <[email protected]>---
net/irda/irias_object.c | 3 --- 1 file changed, 3 deletions(-)net/irda/irias_object.c renamed from net/irda/irias_object.c.old +0
-3@@ -257,7 +257,6 @@/* Unsafe (locking), attrib might change */ return attrib; } -EXPORT_SYMBOL (irias_find_attrib);/* * Function irias_add_attribute (obj, attrib) @@ -484,7 +483,6 @@return value; } -EXPORT_SYMBOL (irias_new_string_value);/* * Function irias_new_octseq_value (octets, len) @@ -519,7 +517,6 @@memcpy (value->t.oct_seq, octseq , len);return value; } -EXPORT_SYMBOL (irias_new_octseq_value);struct ias_value *irias_new_missing_value (void ) {
Quoted 1 line · Jean Tourrilhes
Hi,
Hi Jean,
Quoted 2 lines
You now need to send those patches to :
[email protected]
Samuel, please send a patch to update MAINTAINERS.
Quoted 1 line
Personally, I don't see what this patch buy us...
It makes the kernel image smaller.
Quoted 1 line
Jean
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 10 lines · ext Adrian Bunk
Quoted 1 line · Jean Tourrilhes
Hi,Hi Jean,
Quoted 2 lines
You now need to send those patches to :
[email protected]Samuel, please send a patch to update
MAINTAINERS.
Will do.
Quoted 4 lines
Quoted 2 lines
Personally, I don't see what this patch buy us...
It makes the kernel image smaller.
It's not a lot, but it does make the kernel image smaller. Those 3 symbols do not need to be exported as they are not used anywhere in the modularized parts of the IrDA stack. So, the patch looks good to me.
Cheers,
Samuel.
Quoted 13 lines
Quoted 1 line
Jean
cu
Adrian--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
Quoted 6 lines · ext Adrian Bunk
This patch removes the following unused EXPORT_SYMBOL's:
-irias_find_attrib
-irias_new_string_value
-irias_new_octseq_valueSigned-off-by Adrian Bunk <[email protected]>
Looks good to me.
Quoted 37 lines
---
net/irda/irias_object.c | 3 --- 1 file changed, 3 deletions(-)net/irda/irias_object.c renamed from net/irda/irias_object.c.old +0
-4@@ -257,7 +257,6 @@/* Unsafe (locking), attrib might change */ return attrib; } -EXPORT_SYMBOL (irias_find_attrib);/* * Function irias_add_attribute (obj, attrib) @@ -484,7 +483,6 @@return value; } -EXPORT_SYMBOL (irias_new_string_value);/* * Function irias_new_octseq_value (octets, len) @@ -519,7 +517,6 @@memcpy (value->t.oct_seq, octseq , len);return value; } -EXPORT_SYMBOL (irias_new_octseq_value);struct ias_value *irias_new_missing_value (void ) { -To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
David S. Miller
maintainerFrom: Samuel Ortiz <[email protected]>
Date: Sat, 15 Apr 2006 11:58:21 +0300 (EEST)
Quoted 11 lines · ext Adrian Bunk
Quoted 7 lines
This patch removes the following unused EXPORT_SYMBOL's:
-irias_find_attrib
-irias_new_string_value
-irias_new_octseq_valueSigned-off-by Adrian Bunk <[email protected]>Looks good to me.
Signed-off-by Samuel Ortiz <[email protected]>
Sam, just add this to your IRDA queue. Ok?
Quoted 10 lines · ext David S. Miller
From: Samuel Ortiz <[email protected]>
Date: Sat, 15 Apr 2006 11:58:21 +0300 (EEST)Quoted 7 lines · ext Adrian Bunk
Quoted 6 lines
This patch removes the following unused EXPORT_SYMBOL's:
-irias_find_attrib
-irias_new_string_value
-irias_new_octseq_value
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Adrian Bunk <[email protected]>Looks good to me.
Signed-off-by Samuel Ortiz <[email protected]>Sam, just add this to your IRDA queue. Ok?
Sure, I will.
Quoted 2 lines
Personally, I don't see what this patch buy us...
all the unused exports in the kernel together make a binary kernel 100Kb bigger. It's a case of a lot of little steps I suppose (each export taking like 100 to 150 bytes depending on the size of the function name)
Quoted 5 lines · Arjan van de Ven
Quoted 1 line
Personally, I don't see what this patch buy us...
all the unused exports in the kernel together make a binary kernel 100Kb bigger. It's a case of a lot of little steps I suppose (each export taking like 100 to 150 bytes depending on the size of the function name)
So why are exports taking us 100-150 bytes, not say 20 which is what I'd expect ?
Quoted 10 lines · Alan Cox
Quoted 5 lines · Arjan van de Ven
Quoted 1 line
Personally, I don't see what this patch buy us...
all the unused exports in the kernel together make a binary kernel 100Kb bigger. It's a case of a lot of little steps I suppose (each export taking like 100 to 150 bytes depending on the size of the function name)
So why are exports taking us 100-150 bytes, not say 20 which is what I'd expect ?
there is the name, the crc, the address, a module name thingy (which I think is only filled for non-built-in symbols) and I'm sure there's some padding here and there...
About 1/3rd of all exports is unused, so killing those is an easy way to gain back the space...