Skip to contentSkip to conversation

drivers/parport/share.: unexport parport_get_port

PATCH In review Adrian Bunk 2 participants 3 messages Apr 18, 2006 – Apr 19, 2006 Parallel port

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/parport/share.: unexport parport_get_port

This patch removes the unused EXPORT_SYMBOL(parport_get_port).

---

This patch was already sent on:
- 5 Apr 2006

drivers/parport/share.c renamed from drivers/parport/share.c.old +0 -1
@@ -1003,7 +1003,6 @@
 EXPORT_SYMBOL(parport_unregister_driver);
 EXPORT_SYMBOL(parport_register_device);
 EXPORT_SYMBOL(parport_unregister_device);
-EXPORT_SYMBOL(parport_get_port);
 EXPORT_SYMBOL(parport_put_port);
 EXPORT_SYMBOL(parport_find_number);
 EXPORT_SYMBOL(parport_find_base);
#1 lore raw
Quoted 4 lines · Adrian Bunk

This patch removes the unused EXPORT_SYMBOL(parport_get_port).

It may be unused by any drivers that ship with the kernel but it is used by the ppscsi patch to support SCSI over parallel port devices. This export was removed in 2.6.10 and put back in in 2.6.16 so someone else obviously thinks it should be exported.

Quoted 17 lines

---

This patch was already sent on:
- 5 Apr 2006

--- linux-2.6.17-rc1-mm1-full/drivers/parport/share.c.old 2006-04-05
17:12:05.000000000 +0200 +++
linux-2.6.17-rc1-mm1-full/drivers/parport/share.c 2006-04-05
17:12:42.000000000 +0200 @@ -1003,7 +1003,6 @@
EXPORT_SYMBOL(parport_unregister_driver);
EXPORT_SYMBOL(parport_register_device);
EXPORT_SYMBOL(parport_unregister_device);
-EXPORT_SYMBOL(parport_get_port);
EXPORT_SYMBOL(parport_put_port);
EXPORT_SYMBOL(parport_find_number);
EXPORT_SYMBOL(parport_find_base);

#2 lore raw
Quoted 11 lines · Adam Baker
Quoted 4 lines · Adrian Bunk

This patch removes the unused EXPORT_SYMBOL(parport_get_port).

It may be unused by any drivers that ship with the kernel but it is used by the ppscsi patch to support SCSI over parallel port devices. This export was removed in 2.6.10 and put back in in 2.6.16 so someone else obviously thinks it should be exported.
...

That someone else thinks it should be exported hasn't any value.

If the SCSI over parallel port drivers are considered valuable, someone should work on getting them included in the kernel.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed