Skip to contentSkip to conversation

Kernel doesn't compile with CONFIG_HOTPLUG && !CONFIG_NET

PATCH In review Nigel Cunningham 3 participants 4 messages Apr 18, 2006 – Apr 19, 2006 Proc sysctl

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Kernel doesn't compile with CONFIG_HOTPLUG && !CONFIG_NET

Hi.

2.6.17-rc1 doesn't compile if networking support is disabled but hotplug is enabled. This patch addresses that issue.

Please consider applying.

 sysctl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sysctl.c +1 -1
diff -ruNp 9904.patch-old/kernel/sysctl.c 9904.patch-new/kernel/sysctl.c
@@ -401,7 +401,7 @@ static ctl_table kern_table[] = {
 		.strategy	= &sysctl_string,
 	},
 #endif
-#ifdef CONFIG_HOTPLUG
+#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)
 	{
 		.ctl_name	= KERN_HOTPLUG,
 		.procname	= "hotplug",
#1 lore raw

kernel/sysctl.c static ctl_table kern_table[] = { · line 404

Quoted 9 lines · Nigel Cunningham
kernel/sysctl.c +1 -1
@@ -401,7 +401,7 @@ static ctl_table kern_table[] = {
 		.strategy	= &sysctl_string,
 	},
 #endif
-#ifdef CONFIG_HOTPLUG
+#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)

I've had this in -mm for a couple of weeks now but rmk points out that it's rather silly. Because if you have CONFIG_HOTPLUG=y, CONFIG_NET=n then the kernel cannot deliver hotplug events to userspace..

So perhaps CONFIG_HOTPLUG should depend upon CONFIG_NET or, better, CONFIG_NETLINK.

Dunno. I left this in Greg's lap, but he's hiding.

#2 lore raw

Hi.

Quoted 14 lines · Andrew Morton

kernel/sysctl.c static ctl_table kern_table[] = { · line 404

Quoted 8 lines · Nigel Cunningham
kernel/sysctl.c +1 -1
@@ -401,7 +401,7 @@ static ctl_table kern_table[] = {
 		.strategy	= &sysctl_string,
 	},
 #endif
-#ifdef CONFIG_HOTPLUG
+#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)

I've had this in -mm for a couple of weeks now but rmk points out that it's rather silly. Because if you have CONFIG_HOTPLUG=y, CONFIG_NET=n then the kernel cannot deliver hotplug events to userspace..

Quoted 4 lines

So perhaps CONFIG_HOTPLUG should depend upon CONFIG_NET or, better, CONFIG_NETLINK.

Dunno. I left this in Greg's lap, but he's hiding.

:) Ah okay. I guess he's been busy with those mini summits.

Regards,

Nigel

#3 lore raw
In reply to Andrew Morton
Quoted 15 lines · Andrew Morton

kernel/sysctl.c static ctl_table kern_table[] = { · line 404

Quoted 9 lines · Nigel Cunningham
kernel/sysctl.c +1 -1
@@ -401,7 +401,7 @@ static ctl_table kern_table[] = {
 		.strategy	= &sysctl_string,
 	},
 #endif
-#ifdef CONFIG_HOTPLUG
+#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)

I've had this in -mm for a couple of weeks now but rmk points out that it's rather silly. Because if you have CONFIG_HOTPLUG=y, CONFIG_NET=n then the kernel cannot deliver hotplug events to userspace..

Quoted 2 lines

So perhaps CONFIG_HOTPLUG should depend upon CONFIG_NET or, better, CONFIG_NETLINK.

I have a patch in the queue from Kay that should fix this. Hopefully... Will get to it tomorrow.

Quoted 1 line

Dunno. I left this in Greg's lap, but he's hiding.

Hiding? A -stable release a day sure isn't hiding :)

thanks,

greg k-h