Skip to contentSkip to conversation

acpi hotkey sysfs support

DISCUSSION Pavel Machek 2 participants 2 messages Apr 21, 2006 1 message not in the archive ACPI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi!

Quoted 7 lines

I have created a place under sysfs to have a unified place to gather user input for common hotkey features.
http://bugzilla.kernel.org/show_bug.cgi?id=5749#c10

All of you are owner of a specific acpi hotkey driver. Would you like to use that sysfs support to reduce the unnecessary interface complexity.

Yep, patch looks okay. It would be nice to format it linux-like, through. Space between if and (, and such stuff.

SHOUTING_TYPEDEFS look bad to me, too.
Pavel

Signature · 1 line
Thanks for all the (sleeping) penguins.
#2 lore raw

HI!

Quoted 4 lines
Quoted 4 lines

I have created a place under sysfs to have a unified place to gather user input for common hotkey features.
http://bugzilla.kernel.org/show_bug.cgi?id=5749#c10

Quoted 8 lines
Quoted 3 lines

All of you are owner of a specific acpi hotkey driver. Would you like to use that sysfs support to reduce the unnecessary interface complexity.

Yep, patch looks okay. It would be nice to format it linux-like, through. Space between if and (, and such stuff.

SHOUTING_TYPEDEFS look bad to me, too.

One more thing... can we use input api for these events? Routing buttons through /proc/acpi/event was mistake from day 0 :-(.

Pavel

Signature · 1 line
Thanks for all the (sleeping) penguins.