Skip to contentSkip to conversation

use hlist_unhashed()

PATCH New Akinobu Mita 1 participant 1 message Apr 24, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 use hlist_unhashed()

Use hlist_unhashed() rather than accessing inside data structure.

CC "David S. Miller" <[email protected]>
 include/linux/list.h             |    2 +-
 include/net/inet_timewait_sock.h |    2 +-
 include/net/sock.h               |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
include/net/inet_timewait_sock.h +1 -1
Index: 2.6-git/include/net/inet_timewait_sock.h
===================================================================
@@ -150,7 +150,7 @@ static inline void inet_twsk_add_bind_no
 
 static inline int inet_twsk_dead_hashed(const struct inet_timewait_sock *tw)
 {
-	return tw->tw_death_node.pprev != NULL;
+	return !hlist_unhashed(&tw->tw_death_node);
 }
 
 static inline void inet_twsk_dead_node_init(struct inet_timewait_sock *tw)
include/net/sock.h +1 -1
Index: 2.6-git/include/net/sock.h
===================================================================
@@ -279,7 +279,7 @@ static inline int sk_unhashed(const stru
 
 static inline int sk_hashed(const struct sock *sk)
 {
-	return sk->sk_node.pprev != NULL;
+	return !sk_unhashed(sk);
 }
 
 static __inline__ void sk_node_init(struct hlist_node *node)
include/linux/list.h +1 -1
Index: 2.6-git/include/linux/list.h
===================================================================
@@ -619,7 +619,7 @@ static inline void hlist_del_rcu(struct 
 
 static inline void hlist_del_init(struct hlist_node *n)
 {
-	if (n->pprev)  {
+	if (!hlist_unhashed(n)) {
 		__hlist_del(n);
 		INIT_HLIST_NODE(n);
 	}