Skip to contentSkip to conversation

Avoid printing pointless tsc skew msgs.

PATCH Dave Jones 2 participants 2 messages Apr 24, 2006 – Apr 25, 2006

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

These messages are kinda silly..

CPU#0 had 0 usecs TSC skew, fixed it up.
CPU#1 had 0 usecs TSC skew, fixed it up.

inspired from: http://bugzilla.kernel.org/attachment.cgi?id=7713&action=view

arch/i386/kernel/smpboot.c renamed from arch/i386/kernel/smpboot.c~ +2 -1
@@ -313,7 +313,8 @@ static void __init synchronize_tsc_bp (v
 			if (tsc_values[i] < avg)
 				realdelta = -realdelta;
 
-			printk(KERN_INFO "CPU#%d had %ld usecs TSC skew, fixed it up.\n", i, realdelta);
+			if (realdelta > 0)
+				printk(KERN_INFO "CPU#%d had %ld usecs TSC skew, fixed it up.\n", i, realdelta);
 		}
 
 		sum += delta;
#1 lore raw
Quoted 6 lines · Dave Jones

These messages are kinda silly..

CPU#0 had 0 usecs TSC skew, fixed it up.
CPU#1 had 0 usecs TSC skew, fixed it up.

inspired from: http://bugzilla.kernel.org/attachment.cgi?id=7713&action=view

Actually it's not correct because if you fixed it up it won't be 0 usecs again because of the error it adds

(I'm actually not sure how it even managed to measure 0 usecs)

-Andi