forgotten ->b_data in memcpy() call in ext3/resize.c (oopsable)
PATCH 1/1 forgotten ->b_data in memcpy() call in ext3/resize.c (oopsable)
sbi->s_group_desc is an array of pointers to buffer_head. memcpy() of buffer size from address of buffer_head is a bad idea - it will generate junk in any case, may oops if buffer_head is close to the end of slab page and next page is not mapped and isn't what was intended there. IOW, ->b_data is missing in that call. Fortunately, result doesn't go into the primary on-disk data structures, so only backup ones get crap written to them; that had allowed this bug to remain unnoticed until now.
Signed-off-by Al Viro <[email protected]>
---
fs/ext3/resize.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
e26179ed6fdd952b91a313a275191ae97bcd4d71
fs/ext3/resize.c +1 -1
@@ -213,7 +213,7 @@ static int setup_new_group_blocks(struct goto exit_bh; }lock_buffer (bh); -memcpy (gdb->b_data, sbi->s_group_desc[i], bh->b_size); +memcpy (gdb->b_data, sbi->s_group_desc[i]->b_data, bh->b_size);set_buffer_uptodate (gdb);unlock_buffer (bh);ext3_journal_dirty_metadata (handle, gdb);
Signature · 1 line
1.3.0.g0080f