Skip to contentSkip to conversation

s390: bug in setup_rt_frame

PATCH New Heiko Carstens 1 participant 1 message Apr 29, 2006 s390

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 s390: bug in setup_rt_frame

From: Heiko Carstens <[email protected]>

Consider return value of __put_user() when setting up a signal frame instead of ignoring it.

Cc Martin Schwidefsky <[email protected]>

---

Second version of this patch. This time without replacing __NR_rt_sigreturn with __NR_sigreturn...

 arch/s390/kernel/signal.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/s390/kernel/signal.c +3 -2
index ae1927e..d48cfc7 100644
@@ -358,8 +358,9 @@ static int setup_rt_frame(int sig, struc
 	} else {
                 regs->gprs[14] = (unsigned long)
 			frame->retcode | PSW_ADDR_AMODE;
-		err |= __put_user(S390_SYSCALL_OPCODE | __NR_rt_sigreturn,
-	                          (u16 __user *)(frame->retcode));
+		if (__put_user(S390_SYSCALL_OPCODE | __NR_rt_sigreturn,
+			       (u16 __user *)(frame->retcode)))
+			goto give_sigsegv;
 	}
 
 	/* Set up backchain. */