Skip to contentSkip to conversation

bcm43xx: check for valid MAC address in SPROM

PATCH New Stefano Brivio 1 participant 1 message May 4, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcm43xx: check for valid MAC address in SPROM

Please apply to 2.6.17, as it fixes a problem that prevents bcm43xx devices which support 802.11a in addition to 802.11b/g from working, as the MAC address isn't detected correctly. This applies to 2.6.17-rc3.

--

Check for valid MAC address in SPROM fields instead of relying on PHY type while setting the MAC address in the networking subsystem, as some devices have multiple PHYs.

drivers/net/wireless/bcm43xx/bcm43xx_main.c +0 -0
Index: linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
@@ -3482,7 +3482,7 @@
	bcm43xx_pctl_set_crystal(bcm, 0);

	/* Set the MAC address in the networking subsystem */
-	if (bcm43xx_current_phy(bcm)->type == BCM43xx_PHYTYPE_A)
+	if (is_valid_ether_addr(bcm->sprom.et1macaddr))
		memcpy(bcm->net_dev->dev_addr, bcm->sprom.et1macaddr, 6);
	else
		memcpy(bcm->net_dev->dev_addr, bcm->sprom.il0macaddr, 6);

--
Ciao
Stefano