Skip to contentSkip to conversation

+ two-additions-to-linux-documentation-ioctl-numbertxt.patch added to -mm tree

DISCUSSION Alexey Dobriyan 1 participant 1 message May 8, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Documentation/ioctl-number.txt Code Seq# Include File Comments · line 88

Quoted 9 lines · On Mon, May 08, 2006 at 10:48:40AM -0700, [email protected] wrote:

two additions to ./linux/Documentation/ioctl-number.txt

Documentation/ioctl-number.txt renamed from Documentation/ioctl-number.txt~two-additions-to-linux-documentation-ioctl-numbertxt +1 -0
@@ -85,7 +85,9 @@ Code	Seq#	Include File		Comments
 
 'C'	all	linux/soundcard.h
 'D'	all	asm-s390/dasd.h
+'E'	all	linux/input.h

This one is good.

Documentation/ioctl-number.txt Code Seq# Include File Comments · line 90

Quoted 2 lines
Documentation/ioctl-number.txt renamed from Documentation/ioctl-number.txt~two-additions-to-linux-documentation-ioctl-numbertxt +1 -0
 'F'	all	linux/fb.h
+'H'	all	linux/hiddev.h

Quick grep shows 'H' namespace is kinda-sorta divided between some bluetooth headers, hiddev.h (as was correctly noted) and sound SNDRV_*. Of course, it's worse because ALSA and hiddev.h ioctls conflict pretty often.

Was second column "Seq#" meant to be central registration point of new ioctls? If it's, boundaries are not obeyed and comments like

	/*
	 * IOCTLS (0x00 - 0x7f)
	 */

should be removed probably from everywhere to not give false sense of ownership TOGETHER with rejecting every new conflicting ioctl.