Skip to contentSkip to conversation

i386/x86_64: Force pci=noacpi on HP XW9300

PATCH Jeff Garzik 2 participants 5 messages May 16, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 27 lines · Linux Kernel Mailing List

commit 5491d0f3e206beb95eeb506510d62a1dab462df1
tree 5c4aadcfb4a93535e2f6e0f5977e930ccacec0e9
parent f0fdabf8bf187c9aafeb139a828c530ef45cf022
author Andi Kleen <[email protected]> Mon, 15 May 2006 18:19:41 +0200 committer Linus Torvalds <[email protected]> Tue, 16 May 2006 21:59:31 -0700

[PATCH] i386/x86_64: Force pci=noacpi on HP XW9300

This is needed to see all devices.

The system has multiple PCI segments and we don't handle that properly yet in PCI and ACPI. Short term before this is fixed blacklist it to pci=noacpi.

 arch/i386/kernel/acpi/boot.c |    8 ++++++++
 1 files changed, 8 insertions(+)
arch/i386/kernel/acpi/boot.c +0 -0
index 40e5aba..daee695 100644

arch/i386/kernel/acpi/boot.c static struct dmi_system_id __initdata a · line 1074

Quoted 9 lines
arch/i386/kernel/acpi/boot.c +6 -0
@@ -1066,6 +1066,14 @@ static struct dmi_system_id __initdata a
 		     DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 360"),
 		     },
 	 },
+	{
+	 .callback = disable_acpi_pci,
+	 .ident = "HP xw9300",
+	 .matches = {
+		    DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+		    DMI_MATCH(DMI_PRODUCT_NAME, "HP xw9300 Workstation"),

Strong NAK. Please revert. This majorly screws my primary workstation, and many other users with this workstation.

At a minimum, you should test to see if the BIOS has activated PCI domain support first!

Jeff

#2 lore raw
Quoted 32 lines · Jeff Garzik
Quoted 31 lines · Linux Kernel Mailing List

commit 5491d0f3e206beb95eeb506510d62a1dab462df1
tree 5c4aadcfb4a93535e2f6e0f5977e930ccacec0e9
parent f0fdabf8bf187c9aafeb139a828c530ef45cf022
author Andi Kleen <[email protected]> Mon, 15 May 2006 18:19:41 +0200 committer Linus Torvalds <[email protected]> Tue, 16 May 2006 21:59:31 -0700

[PATCH] i386/x86_64: Force pci=noacpi on HP XW9300

This is needed to see all devices.

The system has multiple PCI segments and we don't handle that properly yet in PCI and ACPI. Short term before this is fixed blacklist it to pci=noacpi.

 arch/i386/kernel/acpi/boot.c |    8 ++++++++
 1 files changed, 8 insertions(+)
arch/i386/kernel/acpi/boot.c +1 -0
index 40e5aba..daee695 100644
@@ -1066,6 +1066,14 @@ static struct dmi_system_id __initdata a
 		     DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 360"),
 		     },
 	 },
+	{
Quoted 8 lines

arch/i386/kernel/acpi/boot.c static struct dmi_system_id __initdata a · line 1074

Quoted 5 lines
arch/i386/kernel/acpi/boot.c +5 -0
+	 .callback = disable_acpi_pci,
+	 .ident = "HP xw9300",
+	 .matches = {
+		    DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+		    DMI_MATCH(DMI_PRODUCT_NAME, "HP xw9300 Workstation"),

Strong NAK. Please revert. This majorly screws my primary workstation, and many other users with this workstation.

Did you test that? I had two persons with that workstation test all combinations and it worked for them.

Wait - you have a engineering sample haven't you? I don't think i care about those. Maybe they behave differently. Use pci=acpi

[Don't try to update the BIOS either - it can be deadly]

Quoted 2 lines

At a minimum, you should test to see if the BIOS has activated PCI domain support first!

It worked in both cases on the production system. Without pci=noacpi the PCI-X bus couldn't be seen.

-Andi

#3 lore raw
Quoted 2 lines · Andi Kleen

Did you test that? I had two persons with that workstation test all combinations and it worked for them.

Not yet, it's queued for my next test run.

Quoted 4 lines

Wait - you have a engineering sample haven't you? I don't think i care about those. Maybe they behave differently. Use pci=acpi

[Don't try to update the BIOS either - it can be deadly]

Well, its a free sample of a production machine, not a pre-production machine. And the BIOS updates just fine :)

Jeff

#4 lore raw
Quoted 5 lines · Jeff Garzik
Quoted 2 lines · Andi Kleen

Did you test that? I had two persons with that workstation test all combinations and it worked for them.

Not yet, it's queued for my next test run.

You complained without testing anything?

-Andi

#5 lore raw
Quoted 7 lines · Andi Kleen
Quoted 4 lines · Jeff Garzik
Quoted 2 lines · Andi Kleen

Did you test that? I had two persons with that workstation test all combinations and it worked for them.

Not yet, it's queued for my next test run.

You complained without testing anything?

When I first got the box, pci=noacpi made mmconfig space go away, or some other breakage. If your patch forces that, then logically that condition should reappear by default.

Jeff