ATI Remote Control improvements
Sorry for the delay in responding, been busy on other things. Answers in line...
List: linux-kernel Subject: Re: [PATCH] ATI Remote Control improvements From: Ville_Syrjälä <syrjala () sci ! fi> Date: 2006-05-10 14:39:08 Message-ID: pan.2006.05.10.14.39.06.406060 () sci ! fi
[Download message RAW]
Quoted 4 lines · Daniel Sherwood
Hi
Please find below a patch to improve the
functionality of the ATI Remote
Quoted 3 lines
Control as follows.
* Fixed handling of double-click
BTN_XXXevents that
require the
Quoted 1 line
input_eventtimestamp to change between press and
release events.
Quoted 1 line
* Added module parameter 'xkeycodesonly' to prevent
driver generating
Quoted 1 line
keycodes that are not recognised by X windows.
(disabled by default)
Quoted 1 line
Quoted 1 line
Why?
Because I have not found ay other way to get these keys to be recognised by X-windows (xev doesn't give any feedback on these keys). If there is another way then I am happy to use it.
Quoted 1 line
* Added module parameter 'selectiverepeat' to make
driver only generate
Quoted 1 line
key repeats for certain keys such and cursor and
volume. (disabled by
Quoted 4 lines
default)
Quoted 2 lines
Sounds like this sort of thing could be handled in userspace.
My rationalle here is that the sensitivity of the remote seems to drop rapidly at around 4-5 meters and I find that I end up holding the keys for a while before it responds. With key-repeats enabled I quite often ended up with multiple keys being actionned. This became quite frustrating so it seemed easier that only certain keys did repeats. Mt system now appears much more responsive and easier to use.
Quoted 1 line
* Modified filter and key repate support to use
millisecond values set
Quoted 1 line
by 'filtertime', 'repeatdelay' & 'repeatrate' module
parameters.
Quoted 1 line
Quoted 1 line
REP_DELAYandREP_PERIOD?
What do you mean by this? Am I using the wrong terminology or are you suggesting that there is a standard way of doing this (IOCTL?). If so, then I can look into modifying it to use this method.
Quoted 1 line
* Added module parameters 'mouseascursor' &
'mouseascursordefault' to
Quoted 1 line
allow the mouse area to behave as the normal
cursor-keys. This
Quoted 1 line
functionality can optionally be switched with the
'HAND' key. (disabled
Quoted 3 lines
by default)
Quoted 1 line
IIRC it already has cursor keys. Why does it need
more of them?
It does indeed already have cursors, but in my application (MythTV) there is (in general) no need for a mouse. I find that whenever someone else tries to use the system, they naturally go for the nice big cursor pad at the top of the remote rather than the ones at the bottom.
Quoted 1 line
* Added module parameter 'mousedoubleclick' to make
the double-click
Quoted 1 line
events actually send two clicks of
BTN_LEFTor
BTN_RIGHT rather than
Quoted 3 lines
BTN_SIDEorBTN_EXTRA. (disabled by default)Without specifying module options, the behaviour
will be the same as the
Quoted 1 line
previous version except for the
BTN_XXXclick fix
and the filter and key
Quoted 11 lines
repeat handling.
(quoted diff) +8
-0+ if (kind == KIND_BUTTON) { + struct timeval then, now; + int loop = 1000000; + input_sync(dev); + do_gettimeofday(&then); + do { + do_gettimeofday(&now); + } while( timeval_compare(&now, &then) ==
Quoted 3 lines
0 && loop-- );
Quoted 1 line
Is this for the timestamp thing? Use
udelay()?
Yes, this is for the timestamp thing. I guess udelay() would be an alternative solution provided that it can be garunteed to be synchronous with and have the same resolution as do_gettimeofday(). Do you know if udelay(0) or udelay(1) will wait until the next usec edge or the next edge plus one? Overall, I am not entirely happy with sticking a live-waiting-loop in the driver, however in this case it is only for less than 1 microsecond and only when the mouse button click events are used so it shouldn't be a problem. A more reliable solution (for all drivers) might be to modify the core input handling drivers to ensure that the timestamp is always artificially increased between events that occur on the same timestamp, but this would obviously complicate the core code to ensure it corrected any offset as soon as possible and might have other unforseen side-effects.
Signature · 16 lines
Ville Syrjälä [email protected] http://www.sci.fi/~syrjala/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ [prev in list] [next in list] [prev in thread] [next in thread] Send instant messages to your online friends http://uk.messenger.yahoo.com