Skip to contentSkip to conversation

2.6.17-rc6 perfmon2 patch for review: new sysfs support

PATCH Chuck Ebbert 2 participants 2 messages Jun 18, 2006 – Jun 19, 2006

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Quoted 2 lines · Stephane Eranian
perfmon/perfmon_sysfs.c 2006-06-08 05:36:31.000000000 -0700 renamed from perfmon/perfmon_sysfs.c 1969-12-31 16:00:00.000000000 -0800 +0 -0

...

perfmon/perfmon_sysfs.c 2006-06-08 05:36:31.000000000 -0700

Quoted 6 lines
perfmon/perfmon_sysfs.c 2006-06-08 05:36:31.000000000 -0700 renamed from perfmon/perfmon_sysfs.c 1969-12-31 16:00:00.000000000 -0800 +6 -0
+struct pfm_controls pfm_controls = {
+     .sys_group = PFM_GROUP_PERM_ANY,
+     .task_group = PFM_GROUP_PERM_ANY,
+     .arg_size_max = PAGE_SIZE,
+     .smpl_buf_size_max = ~0,
+};

This means that by default anyone can create monitoring sessions. It should start out as restrictive as possible; the admin can relax permissions as needed.

Signature · 2 lines
Chuck
 "You can't read a newspaper if you can't read."  --George W. Bush
#1 lore raw

Chuck,

Quoted 7 lines · Chuck Ebbert

In-Reply-To: <[email protected]>

Quoted 2 lines · Stephane Eranian
perfmon/perfmon_sysfs.c 2006-06-08 05:36:31.000000000 -0700 renamed from perfmon/perfmon_sysfs.c 1969-12-31 16:00:00.000000000 -0800 +0 -0

...

Quoted 8 lines

perfmon/perfmon_sysfs.c 2006-06-08 05:36:31.000000000 -0700

Quoted 6 lines
perfmon/perfmon_sysfs.c 2006-06-08 05:36:31.000000000 -0700 renamed from perfmon/perfmon_sysfs.c 1969-12-31 16:00:00.000000000 -0800 +6 -0
+struct pfm_controls pfm_controls = {
+     .sys_group = PFM_GROUP_PERM_ANY,
+     .task_group = PFM_GROUP_PERM_ANY,
+     .arg_size_max = PAGE_SIZE,
+     .smpl_buf_size_max = ~0,
+};

This means that by default anyone can create monitoring sessions.

Yes.

Quoted 3 lines

It should start out as restrictive as possible; the admin can relax permissions as needed.

I would expect distros to set it in a more restrictive way. That is what I have observed with the Resources Limits such as RLIMIT_MEMLOCK, for instance.

I am not sure what the mainline policy is on this.

I am glad you looked at that permission code because I found a bug there related to sys_group/task_group.

Thanks.

Signature · 1 line
-Stephane