Skip to contentSkip to conversation

drivers/mtd/devices/: remove dead _ecc code

PATCH In review Adrian Bunk 2 participants 4 messages Jun 21, 2006 – Jun 28, 2006 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/mtd/devices/: remove dead _ecc code

This patch removes some code that is dead code after the "Remove read/write _ecc variants" patch that went into Linus' tree.

---

 drivers/mtd/devices/Kconfig       |    4 
 drivers/mtd/devices/Makefile      |    1 
 drivers/mtd/devices/doc2000.c     |  100 -----
 drivers/mtd/devices/doc2001.c     |   94 -----
 drivers/mtd/devices/doc2001plus.c |  109 ------
 drivers/mtd/devices/docecc.c      |  527 ------------------------------
 include/linux/mtd/doc2000.h       |    2 
 7 files changed, 18 insertions(+), 819 deletions(-)
drivers/mtd/devices/Kconfig renamed from drivers/mtd/devices/Kconfig.old +0 -4
@@ -213,10 +213,6 @@
 
 config MTD_DOCPROBE
 	tristate
-	select MTD_DOCECC
-
-config MTD_DOCECC
-	tristate
 
 config MTD_DOCPROBE_ADVANCED
 	bool "Advanced detection options for DiskOnChip"
drivers/mtd/devices/Makefile renamed from drivers/mtd/devices/Makefile.old +0 -1
@@ -7,7 +7,6 @@
 obj-$(CONFIG_MTD_DOC2001)	+= doc2001.o
 obj-$(CONFIG_MTD_DOC2001PLUS)	+= doc2001plus.o
 obj-$(CONFIG_MTD_DOCPROBE)	+= docprobe.o
-obj-$(CONFIG_MTD_DOCECC)	+= docecc.o
 obj-$(CONFIG_MTD_SLRAM)		+= slram.o
 obj-$(CONFIG_MTD_PHRAM)		+= phram.o
 obj-$(CONFIG_MTD_PMC551)	+= pmc551.o
drivers/mtd/devices/doc2000.c renamed from drivers/mtd/devices/doc2000.c.old +5 -95

151 lines not on this page · raw message

drivers/mtd/devices/doc2001.c renamed from drivers/mtd/devices/doc2001.c.old +5 -89

132 lines not on this page · raw message

drivers/mtd/devices/doc2001plus.c renamed from drivers/mtd/devices/doc2001plus.c.old +8 -101

151 lines not on this page · raw message

include/linux/mtd/doc2000.h renamed from include/linux/mtd/doc2000.h.old +0 -2
@@ -190,6 +190,4 @@
 	struct mutex lock;
 };
 
-int doc_decode_ecc(unsigned char sector[512], unsigned char ecc1[6]);
-
 #endif /* __MTD_DOC2000_H__ */
drivers/mtd/devices/docecc.c deleted +0 -527

527 lines not on this page · raw message

#1 lore raw
Quoted 2 lines · Adrian Bunk

This patch removes some code that is dead code after the "Remove read/write _ecc variants" patch that went into Linus' tree.

Holy cow, are you even remotly knowing what you are doing ?

Removing the xxx_ecc function pointers from the mtd structs does not remove the fundamental requirement of ECC for NAND FLASH.

I'm just waiting for the follow up patches which remove nand_ecc and the reed solomon library.

When you're done with those, please remove NAND support entirely.

Quoted 1 line
#2 lore raw
Quoted 4 lines · Thomas Gleixner
Quoted 2 lines · Adrian Bunk

This patch removes some code that is dead code after the "Remove read/write _ecc variants" patch that went into Linus' tree.

Quoted 8 lines

Holy cow, are you even remotly knowing what you are doing ?

Removing the xxx_ecc function pointers from the mtd structs does not remove the fundamental requirement of ECC for NAND FLASH.

I'm just waiting for the follow up patches which remove nand_ecc and the reed solomon library.
...

nand_ecc isn't dead code.

But if I do understand correctly, you have pending patches to let the code your patch made dead code and my patch would have removed be used again?

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 5 lines · Adrian Bunk

nand_ecc isn't dead code.

But if I do understand correctly, you have pending patches to let the code your patch made dead code and my patch would have removed be used again?

Ooops, sorry for shooting too fast. You're right I rendered that stuff dead unintentionally. But removing is not an option. I fix it proper

Thanks

tglx