Skip to contentSkip to conversation

ACKVEC: fix ackvector length calculation

PATCH In review Andrea Bittau 1 participant 1 message Jun 22, 2006 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/11 ACKVEC: fix ackvector length calculation

Fix ackvector length calculation upon receiving an "ack-of-ack". This patch aviods the ackvector from growing too large which causes it to not be inserted into packets.

---

net/dccp/ackvec.c +7 -5
index 8c211c5..8dab723 100644
@@ -353,11 +353,13 @@ static void dccp_ackvec_throw_record(str
 {
 	struct dccp_ackvec_record *next;
 
-	av->dccpav_buf_tail = avr->dccpavr_ack_ptr - 1;
-	if (av->dccpav_buf_tail = 0)
-		av->dccpav_buf_tail = DCCP_MAX_ACKVEC_LEN - 1;
-
-	av->dccpav_vec_len -= avr->dccpavr_sent_len;
+	/* sort out vector length */
+	if (av->dccpav_buf_head <= avr->dccpavr_ack_ptr)
+		av->dccpav_vec_len = avr->dccpavr_ack_ptr - av->dccpav_buf_head;
+	else
+		av->dccpav_vec_len = DCCP_MAX_ACKVEC_LEN - 1
+				     - av->dccpav_buf_head
+				     + avr->dccpavr_ack_ptr;
 
 	/* free records */
 	list_for_each_entry_safe_from(avr, next, &av->dccpav_records,