Skip to contentSkip to conversation

kmalloc arguments in wrong order (53c700)

PATCH In review Al Viro 4 participants 4 messages Jun 22, 2006 – Jun 23, 2006

Subsystems (3)
lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 kmalloc arguments in wrong order (53c700)

Could people please run make C=2 at some point?

---

 drivers/scsi/53c700.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

c14b0d0f9f7df1aeb96e1651927ea902368e3175

drivers/scsi/53c700.c +1 -1
index 3c683dc..bff0479 100644
@@ -2044,7 +2044,7 @@ NCR_700_slave_configure(struct scsi_devi
 	struct NCR_700_Host_Parameters *hostdata = 
 		(struct NCR_700_Host_Parameters *)SDp->host->hostdata[0];
 
-	SDp->hostdata = kmalloc(GFP_KERNEL, sizeof(struct NCR_700_sense));
+	SDp->hostdata = kmalloc(sizeof(struct NCR_700_sense), GFP_KERNEL);
 
 	if (!SDp->hostdata)
 		return -ENOMEM;
Signature · 1 line
1.3.GIT
#1 lore raw
Quoted 1 line · Al Viro

Could people please run make C=2 at some point?

Is "sparse" packaged somewhere?

Doug Gilbert

#2 lore raw
Quoted 4 lines · On Thu, 22 Jun 2006 20:46:31 -0400 Douglas Gilbert wrote:
Quoted 1 line · Al Viro

Could people please run make C=2 at some point?

Is "sparse" packaged somewhere?

Source tarball snapshots of it are (if you have a git aversion) at http://www.codemonkey.org.uk/projects/git-snapshots/sparse/

I don't know of any binary packages for it. Some distros may do that, but it's so very easy to build from source.

---
~Randy

#3 lore raw
In reply to Douglas Gilbert
Quoted 4 lines · Douglas Gilbert
Quoted 1 line · Al Viro

Could people please run make C=2 at some point?

Is "sparse" packaged somewhere?

I don't think it is, but it is easy enough to build.

git clone git://git.kernel.org/pub/scm/devel/sparse/sparse.git
cd sparse
make
make install

should do it.

Modern gcc's give a ton of

warning: value computed is not used

warnings, but quite frankly, that's a gcc bug, not a a sparse problem.

Linus