x86_64: Move export symbols to their C functions
Review
Quoted 13 lines · Linux Kernel
commit
2ee60e17896c65da1df5780d3196c050bccb7d10
tree54b41b23c92a79e44c7f27c697c84c64052cb85d
parent45486f81c9aa07218b73a38cbcf62ffa66e99088
author Andi Kleen <[email protected]> Mon, 26 Jun 2006 13:59:44 +0200 committer Linus Torvalds <[email protected]> Tue, 27 Jun 2006 00:48:22 -0700[PATCH]
x86_64: Move export symbols to their C functionsOnly exports for assembler files are left in
x8664_ksyms.c(quoted diff) +0
-3- -EXPORT_SYMBOL_GPL(set_nmi_callback); -EXPORT_SYMBOL_GPL(unset_nmi_callback);
These two exports were never re-added, which broke modular oprofile.
arch/x86_64/kernel/nmi.c renamed from arch/x86_64/kernel/nmi.c~ +2 -0
@@ -607,11 +607,13 @@ void set_nmi_callback(nmi_callback_t calvmalloc_sync_all ();rcu_assign_pointer (nmi_callback, callback); } +EXPORT_SYMBOL_GPL (set_nmi_callback);void unset_nmi_callback (void ) { nmi_callback = dummy_nmi_callback; } +EXPORT_SYMBOL_GPL (unset_nmi_callback);#ifdef CONFIG_SYSCTL
Signature · 1 line
http://www.codemonkey.org.uk
Quoted 2 lines
These two exports were never re-added, which broke modular oprofile.
Everybody and their dog sent patches for that by now and I assume Linus already merged Andrew's version
-Andi
Quoted 5 lines · Andi Kleen
Quoted 2 lines
These two exports were never re-added, which broke modular oprofile.
Everybody and their dog sent patches for that by now and I assume Linus already merged Andrew's version
Ah, didn't see them, and my tree seems to be stale. Yes, looks fixed.
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Quoted 9 lines · Dave Jones
Quoted 5 lines · Andi Kleen
Quoted 2 lines
These two exports were never re-added, which broke modular oprofile.
Everybody and their dog sent patches for that by now and I assume Linus already merged Andrew's version
Ah, didn't see them, and my tree seems to be stale. Yes, looks fixed.
Actually, I take that back, I was looking at the wrong tree (again). It's not fixed in Linus tree yet in a git pull from a few minutes ago.
Anyone else notice that head-commits is also really slow ? Lately I get commit mails from 12-24hrs earlier from it.
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Quoted 5 lines · Dave Jones
Quoted 4 lines · Dave Jones
Quoted 3 lines · Andi Kleen
Quoted 2 lines
These two exports were never re-added, which broke modular oprofile.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Everybody and their dog sent patches for that by now and I assume Linus already merged Andrew's version
Ah, didn't see them, and my tree seems to be stale. Yes, looks fixed.
Actually, I take that back, I was looking at the wrong tree (again). It's not fixed in Linus tree yet in a git pull from a few minutes ago.
At least Andrew has already sent the patch. I assume it will get in if it hasn't already.
-Andi