Skip to contentSkip to conversation

broken auto-repeat on PS/2 keyboard

DISCUSSION Paolo Ornati 4 participants 6 messages Jun 27, 2006 – Jun 28, 2006 Input drivers

lore
Share & tools
lore
#0 lore raw

Hello,

with current git kernel keyboard repeat for my plain PS/2 keyboard stopped working.

Reverting

	0ae051a19092d36112b5ba60ff8b5df7a5d5d23b

fixes the problem...

Signature · 2 lines
	Paolo Ornati
	Linux 2.6.17-gd2581eb4 on x86_64
maintainer
#1 lore raw
Quoted 10 lines · Paolo Ornati

Hello,

with current git kernel keyboard repeat for my plain PS/2 keyboard stopped working.

Reverting

       0ae051a19092d36112b5ba60ff8b5df7a5d5d23b

fixes the problem...

Paolo,

Thank you for identifying the problem commit. Please try the attached patch, it should fix the problem.

Signature · 1 line
Dmitry

Input: atkbd - fix hardware autorepeat

---
 drivers/input/keyboard/atkbd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/keyboard/atkbd.c +1 -1
Index: linux/drivers/input/keyboard/atkbd.c
===================================================================
@@ -459,7 +459,7 @@ static irqreturn_t atkbd_interrupt(struc
 			}
 
 			input_regs(dev, regs);
-			input_report_key(dev, keycode, value);
+			input_event(dev, EV_KEY, keycode, value);
 			input_sync(dev);
 
 			if (value && add_release_event) {
#2 lore raw
Quoted 4 lines · On Tue, 27 Jun 2006 13:34:26 -0400 "Dmitry Torokhov"…

Paolo,

Thank you for identifying the problem commit. Please try the attached patch, it should fix the problem.

It works :)

Signature · 2 lines
	Paolo Ornati
	Linux 2.6.17-ga39727f2-dirty on x86_64
#3 lore raw
In reply to Dmitry Torokhov

Hi Dmitry,

Quoted 10 lines
Quoted 7 lines

with current git kernel keyboard repeat for my plain PS/2 keyboard stopped working.

Reverting

       0ae051a19092d36112b5ba60ff8b5df7a5d5d23b

fixes the problem...

Thank you for identifying the problem commit. Please try the attached patch, it should fix the problem.

Fixed it for me as well, thanks! Can this fix be pushed upstream now? The lack of repeat was a real pain.

Signature · 1 line
Jean Delvare
#4 lore raw
Quoted 8 lines · On Wed, 28 Jun 2006 13:36:30 +0200 Jean Delvare <[email protected]> wrote:

Hi Dmitry,

Quoted 6 lines
Quoted 6 lines

with current git kernel keyboard repeat for my plain PS/2 keyboard stopped working.

Reverting

       0ae051a19092d36112b5ba60ff8b5df7a5d5d23b
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

fixes the problem...

Thank you for identifying the problem commit. Please try the attached patch, it should fix the problem.

Fixed it for me as well, thanks! Can this fix be pushed upstream now?

http://groups.google.it/group/linux.kernel/browse_frm/thread/17700355fcda1923/05f38a40a23d0ef1?lnk=st&q=group%3Alinux.kernel+author%3ADmitry&rnum=1&hl=en#05f38a40a23d0ef1

Signature · 2 lines
	Paolo Ornati
	Linux 2.6.17-ga39727f2-dirty on x86_64
#5 lore raw
In reply to Jean Delvare
Quoted 8 lines · Jean Delvare

Hi Dmitry,

Quoted 6 lines
Quoted 6 lines

with current git kernel keyboard repeat for my plain PS/2 keyboard stopped working.

Reverting

       0ae051a19092d36112b5ba60ff8b5df7a5d5d23b
Quoted 8 lines
Quoted 4 lines
Quoted 1 line

fixes the problem...

Thank you for identifying the problem commit. Please try the attached patch, it should fix the problem.

Fixed it for me as well, thanks! Can this fix be pushed upstream now? The lack of repeat was a real pain.

Heh, that means noone but me uses softrepeat option, I didn't even notice it was broken. ;)

I already sent pull request to Linus so you should see it soon.

Signature · 1 line
Dmitry