Skip to contentSkip to conversation

chardev: GPIO for SCx200 & PC-8736x: add proper Kconfig, Makefile entries

PATCH Dave Jones 1 participant 1 message Jun 29, 2006 1 message not in the archive Char and misc drivers

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author
#1 lore raw
Quoted 11 lines · Linux Kernel

commit 7a8e2a5ea4cf43c0edd6db56a156549edb0eee98
tree 42a88e7f8de0c22011b8e75fb96255e5360380d8
parent 23916a8e3d8f41aa91474e834ac99808b197c39e
author Jim Cromie <[email protected]> Tue, 27 Jun 2006 16:54:27 -0700 committer Linus Torvalds <[email protected]> Wed, 28 Jun 2006 07:32:43 -0700

[PATCH] chardev: GPIO for SCx200 & PC-8736x: add proper Kconfig, Makefile entries

Replace the temp makefile hacks with proper CONFIG entries, which are also added to Kconfig.
....

Review

Quoted 9 lines
(quoted diff) +9 -0
+
+config NSC_GPIO
+	tristate "NatSemi Base GPIO Support"
+	# selected by SCx200_GPIO and PC8736x_GPIO
+	# what about 2 selectors differing: m != y
+	help
+	  Common support used (and needed) by scx200_gpio and
+	  pc8736x_gpio drivers.  If those drivers are built as
+	  modules, this one will be too, named nsc_gpio

AFAICT, this is x86 only, so the patch below is needed to stop this new option showing up on PPC, IA64, etc..

drivers/char/Kconfig renamed from drivers/char/Kconfig~ +1 -0
@@ -963,6 +963,7 @@ config PC8736x_GPIO
 
 config NSC_GPIO
 	tristate "NatSemi Base GPIO Support"
+	depends on X86_32
 	# selected by SCx200_GPIO and PC8736x_GPIO
 	# what about 2 selectors differing: m != y
 	help
Signature · 1 line
http://www.codemonkey.org.uk