Skip to contentSkip to conversation

64bit Resource: finally enable 64bit resource sizes

PATCH Chris Wedgwood 2 participants 5 messages Jun 29, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

what am i missing here?

arch/i386/Kconfig config X86_PAE · line 535

Quoted 10 lines
arch/i386/Kconfig +1 -0
@@ -529,6 +529,7 @@ config X86_PAE
 	bool
 	depends on HIGHMEM64G
 	default y
+	select RESOURCES_64BIT
 
 # Common NUMA Features
 config NUMA

this isn't a similar option for x86_64, so...

Quoted 10 lines
include/linux/types.h +1 -1
index a021e15..3f23566 100644
@@ -178,9 +178,14 @@ #endif
 #ifdef __KERNEL__
 typedef unsigned __bitwise__ gfp_t;
 
-typedef unsigned long resource_size_t;
+#ifdef CONFIG_RESOURCES_64BIT

include/linux/types.h #endif · line 191

Quoted 10 lines
include/linux/types.h +5 -0
+typedef u64 resource_size_t;
+#else
+typedef u32 resource_size_t;
 #endif
 
+#endif	/* __KERNEL__ */
+
 struct ustat {
 	__kernel_daddr_t	f_tfree;
 	__kernel_ino_t		f_tinode;

means that on x86_64 resource_size_t will ot be 32-bit when previously it was 64

#2 lore raw
Quoted 10 lines · Chris Wedgwood

what am i missing here?

Quoted 8 lines
arch/i386/Kconfig +1 -0
@@ -529,6 +529,7 @@ config X86_PAE
 	bool
 	depends on HIGHMEM64G
 	default y
+	select RESOURCES_64BIT
 
Quoted 4 lines

arch/i386/Kconfig config X86_PAE · line 535

Quoted 2 lines
arch/i386/Kconfig +0 -0
 # Common NUMA Features
 config NUMA

this isn't a similar option for x86_64, so...

+config RESOURCES_64BIT

+       bool "64 bit Memory and IO resources (EXPERIMENTAL)" if (!64BIT && EXPERIMENTAL)
+       default 64BIT
+       help

+ This option allows memory and IO resources to be 64 bit.

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#3 lore raw

On Thu, Jun 29, 2006 at 04:45:27PM -0400, Dave Jones wrote:

Yeah I just test and it does the right think for iamd64

Review

Quoted 3 lines
(quoted diff) +3 -0
+config RESOURCES_64BIT
+       bool "64 bit Memory and IO resources (EXPERIMENTAL)" if (!64BIT && EXPERIMENTAL)
+       default 64BIT
                  ^^^^^ ?

is that right?

#4 lore raw
Quoted 9 lines · Chris Wedgwood

On Thu, Jun 29, 2006 at 04:45:27PM -0400, Dave Jones wrote:

Yeah I just test and it does the right think for iamd64

Review

Quoted 3 lines
(quoted diff) +3 -0
+config RESOURCES_64BIT
+       bool "64 bit Memory and IO resources (EXPERIMENTAL)" if (!64BIT && EXPERIMENTAL)
+       default 64BIT
                  ^^^^^ ?

is that right?

arch/x86_64/Kconfig has ..

config 64BIT
def_bool y

so why not ?

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#5 lore raw
Quoted 11 lines · Dave Jones
Quoted 3 lines
Quoted 1 line

+ default 64BIT

                  ^^^^^ ?

is that right?

arch/x86_64/Kconfig has ..

config 64BIT
def_bool y

so why not ?

sorry, i wasn't aware you could put tokens like that on the RHS but yes, it seems to work just fine, so ignore me