Skip to contentSkip to conversation

add new types for ext2

RFC PATCH New [email protected] 1 participant 1 message Jun 30, 2006

lore
Share & tools
lore
#0 lore raw

cover add new types for ext2

Hi all,

Quoted 10 lines · On June 29, 2006, I wrote:

There are two new types in Mingming's patches. One is "ext3_fsblk_t" for filesystem relative block and the other is "ext3_grpblk_t" for blockgroup relative offset. But they have no type for file relative offset. Moreover variables for file relative offset are used as various types(int, long and unsigned long) in current kernel.

Therefore I added "ext3_fileblk_t" for file relative offset. It gives unity, which makes maintenance easier and code clearer. ext3_fileblk_t is unsigned long which is the maximum size of current type for file relative offset.

I added the following three types for ext2(like ext3).

typedef unsigned long ext2_fsblk_t; (for filesystem relative block) typedef long ext2_grpblk_t; (for group relative block) typedef unsigned long ext2_fileblk_t; (for file relative offset)

This series of patches give unity, which make maintenance easier and code clearer.

[patch 1/3] ext2_fsblk_t.patch
convert ext2 filesystem blocks to ext2_fsblk_t

[patch 2/3] ext2_grpblk_t.patch
convert ext2 group blocks to ext2_grpblk_t

[patch 3/3] ext2_fileblk_t.patch
convert ext2 file offset to ext2_fileblk_t

Any comments?

sho