libiptc symbols clash
PATCH 1/1 libiptc symbols clash
As reported by Dmitry Levin, the TC_NUM_RULES and TC_GET_RULE exports clash. His patch below, resolving bug #456
Phil
libiptc/libip4tc.c +2 -0
@@ -94,6 +94,8 @@#define TC_FREE iptc_free#define TC_COMMIT iptc_commit#define TC_STRERROR iptc_strerror +#define TC_NUM_RULES iptc_num_rules +#define TC_GET_RULE iptc_get_rule#define TC_AF AF_INET#define TC_IPPROTO IPPROTO_IP
libiptc/libip6tc.c +2 -0
@@ -89,6 +89,8 @@#define TC_FREE ip6tc_free#define TC_COMMIT ip6tc_commit#define TC_STRERROR ip6tc_strerror +#define TC_NUM_RULES ip6tc_num_rules +#define TC_GET_RULE ip6tc_get_rule#define TC_AF AF_INET6#define TC_IPPROTO IPPROTO_IPV6
Quoted 2 lines · Phil Oester
As reported by Dmitry Levin, the
TC_NUM_RULESandTC_GET_RULEexports clash. His patch below, resolving bug #456
What does clash mean in this context? They both end up in different binaries, so I think I might be misunderstanding you.
Quoted 6 lines · Patrick McHardy
Quoted 2 lines · Phil Oester
As reported by Dmitry Levin, the
TC_NUM_RULESandTC_GET_RULEexports clash. His patch below, resolving bug #456What does clash mean in this context? They both end up in different binaries, so I think I might be misunderstanding you.
They end up in libiptc.a twice:
# readelf -s libiptc.a | grep TC
56: 00000b70 81 FUNC GLOBAL DEFAULT 1 TC_GET_RULE
57: 00000bd0 56 FUNC GLOBAL DEFAULT 1 TC_NUM_RULES
57: 00000c10 81 FUNC GLOBAL DEFAULT 1 TC_GET_RULE
58: 00000c70 56 FUNC GLOBAL DEFAULT 1 TC_NUM_RULESinstead of with the standard iptc_ and ip6tc_ naming.
Phil
Quoted 13 lines · Phil Oester
Quoted 7 lines · Patrick McHardy
Quoted 2 lines · Phil Oester
As reported by Dmitry Levin, the
TC_NUM_RULESandTC_GET_RULEexports clash. His patch below, resolving bug #456What does clash mean in this context? They both end up in different binaries, so I think I might be misunderstanding you.
They end up in libiptc.a twice:
Quoted 7 lines
# readelf -s libiptc.a | grep TC 56: 00000b70 81 FUNC GLOBAL DEFAULT 1 TC_GET_RULE 57: 00000bd0 56 FUNC GLOBAL DEFAULT 1 TC_NUM_RULES 57: 00000c10 81 FUNC GLOBAL DEFAULT 1 TC_GET_RULE 58: 00000c70 56 FUNC GLOBAL DEFAULT 1 TC_NUM_RULESinstead of with the standard
iptc_andip6tc_naming.
I wonder why nothing seems to complain about this. Applied, thanks.