Skip to contentSkip to conversation

EXT3: ext3 block bitmap leakage

PATCH-2.4 Willy Tarreau 1 participant 1 message Jul 1, 2006

lore
Share & tools
lore
#0 lore raw

Hi Marcelo,

we missed this patch sent by Kirill Korotaev on LKML. Fortunately, Roberto noticed it and forwarded it to me.

Since it's been there for a very long time, there's no emergency, but the problem looks real and the fix seems to be confirmed, so if you have not closed 2.4.33 yet, it might be worth merging it too.

Here it is as a git patch, but I've queued it in -upstream if you prefer.

Cheers,
Willy

Quoted 1 line

From nobody Mon Sep 17 00:00:00 2001

From: Kirill Korotaev <[email protected]>
Date: Fri, 30 Jun 2006 13:41:05 +0400
Subject: [PATCH] EXT3: ext3 block bitmap leakage

This patch fixes ext3 block bitmap leakage,
which leads to the following fsck messages on
_healthy_ filesystem:
Block bitmap differences: -64159 -73707

All kernels up to 2.6.17 have this bug.

Found by
Vasily Averin <[email protected]> and Andrey Savochkin <[email protected]>
Test case triggered the issue was created by
Dmitry Monakhov <[email protected]>

---

 fs/ext3/inode.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

8c6f6cf38bc9b04edc69c2869ae1e6c584584b4f

fs/ext3/inode.c +1 -0
index bcd86f6..d8f5a9b 100644
@@ -570,6 +570,7 @@ static int ext3_alloc_branch(handle_t *h
 
 	branch[0].key = cpu_to_le32(parent);
 	if (parent) {
+		keys = 1;
 		for (n = 1; n < num; n++) {
 			struct buffer_head *bh;
 			/* Allocate the next block */
Signature · 1 line
1.3.3