Skip to contentSkip to conversation

ACPI: disable SBS by default

PATCH In review Dmitry Torokhov 3 participants 3 messages Jul 6, 2006 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: disable SBS by default

From: Dmitry Torokhov <[email protected]>

ACPI: disable SBS by default

Kconfig help even says that SBS is pretty rare and already obsolete so it does not make sence to keep it enabled.

---

 drivers/acpi/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/Kconfig +1 -1
Index: work/drivers/acpi/Kconfig
===================================================================
@@ -357,7 +357,7 @@ config ACPI_SBS
 	tristate "Smart Battery System (EXPERIMENTAL)"
 	depends on X86 && I2C
 	depends on EXPERIMENTAL
-	default y
+	default n
 	help
 	  This driver adds support for the Smart Battery System.
 	  Depends on I2C (Device Drivers ---> I2C support)
#1 lore raw
Quoted 6 lines · --- Dmitry Torokhov

From: Dmitry Torokhov <[email protected]>

ACPI: disable SBS by default

Kconfig help even says that SBS is pretty rare and already obsolete so it does not make sence to keep it enabled.

it is not rare (see SBS related trafic on this list in last weeks and even months).
How can it be already obsolete? What is a replacement for that driver?

Signature · 1 line
Fryderyk Dziarmagowski
#2 lore raw
Quoted 4 lines · Fryderyk Dziarmagowski
Quoted 2 lines · --- Dmitry Torokhov

From: Dmitry Torokhov <[email protected]>

Quoted 9 lines
Quoted 4 lines

ACPI: disable SBS by default

Kconfig help even says that SBS is pretty rare and already obsolete so it does not make sence to keep it enabled.

it is not rare (see SBS related trafic on this list in last weeks and even months).
How can it be already obsolete? What is a replacement for that driver?

I am relying on author's description here. Here is what Kconfig help says:

"This driver adds support for the Smart Battery System. Depends on I2C (Device Drivers ---> I2C support). A "Smart Battery" is quite old and quite rare compared to today's ACPI "Control Method" battery."

Note that "quite old and rare". Besides, the patch does not remove the driver, it just makes it not enabled in default build as not every box has an SBS.

Signature · 1 line
Dmitry