Skip to contentSkip to conversation

spinlocks: remove 'volatile'

PATCH Chuck Ebbert 2 participants 2 messages Jul 7, 2006

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Review

Quoted 11 lines · Linus Torvalds
Quoted 3 lines

So I _think_ that we should change the "=m" to the much more correct "+m" at the same time (or before - it's really a bug-fix regardless) as removing the "volatile".

Here's a first cut (UNTESTED!) for x86. I didn't check any other architectures, I bet they have similar problems.

 #define __raw_spin_unlock_string \
      "movb $1,%0" \
(quoted diff) +1 -1
-             :"=m" (lock->slock) : : "memory"
+             :"+m" (lock->slock) : : "memory"

This really is just an overwrite of whatever is there. OTOH I can't see how this change could hurt anything..

Signature · 2 lines
Chuck
 "You can't read a newspaper if you can't read."  --George W. Bush
#1 lore raw
Quoted 8 lines · Chuck Ebbert

Review

Quoted 5 lines
 #define __raw_spin_unlock_string \
      "movb $1,%0" \
(quoted diff) +1 -1
-             :"=m" (lock->slock) : : "memory"
+             :"+m" (lock->slock) : : "memory"

This really is just an overwrite of whatever is there. OTOH I can't see how this change could hurt anything..

Yeah, I don't think any non-buggy sequence can make it matter.

In theory, you could have something like

- create a spinlock already locked
- add the object that contains the spinlock to some global queues
- do some op on the object to finalize it
- unlock the spinlock

and then the "unlock" had better not optimize away the previous initialization.

HOWEVER, it can't really do that anyway, since anything that made the spinlock visible to anybody else would have had to serialize the lock state for _that_, so if the "+m" vs "=m" makes a difference, you'd have had a serious bug already for other reasons.

I'll leave it with a "+m". I've tested it locally, and looking at the patch it definitely fixes real bugs in the inline asms, but I still hope other people will take a look before I commit it, in case there are any other subtle cases.

(A "+m" should always be safer than a "=m", so the patch should be very safe, but hey, bugs happen to "obvious" code too)

Linus