Skip to contentSkip to conversation

typo in firmware.sh

PATCH In review Martin Langer 4 participants 4 messages Jul 10, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 typo in firmware.sh

This looks like a missing slash typo in firmware.sh.

firmware/firmware.sh renamed from firmware/firmware.sh.ORIGINAL +1 -1
@@ -9,7 +9,7 @@
     fi
 }
 
-if [ ! -e /sys$DEVPATH/loading ]; then
+if [ ! -e /sys/$DEVPATH/loading ]; then
     err "udev firmware loader misses sysfs directory"
     exit 1
 fi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

#1 lore raw
Quoted 8 lines · Martin Langer

This looks like a missing slash typo in firmware.sh.

firmware/firmware.sh line 15

Quoted 8 lines
firmware/firmware.sh renamed from firmware/firmware.sh.ORIGINAL +1 -1
@@ -9,7 +9,7 @@
     fi
 }
 
-if [ ! -e /sys$DEVPATH/loading ]; then
+if [ ! -e /sys/$DEVPATH/loading ]; then
     err "udev firmware loader misses sysfs directory"
     exit 1
 fi

DEVPATH always starts with a slash.

Kay

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

#2 lore raw
In reply to Martin Langer

firmware/firmware.sh line 12

Quoted 4 lines · Martin Langer

This looks like a missing slash typo in firmware.sh.

firmware/firmware.sh renamed from firmware/firmware.sh.ORIGINAL +1 -1
-if [ ! -e /sys$DEVPATH/loading ]; then
+if [ ! -e /sys/$DEVPATH/loading ]; then

$DEVPATH is something that already begins with a slash.

Signature · 12 lines
Alexander E. Patrakov


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
#3 lore raw
In reply to Martin Langer

firmware/firmware.sh line 12

Quoted 13 lines · Martin Langer

This looks like a missing slash typo in firmware.sh.

firmware/firmware.sh renamed from firmware/firmware.sh.ORIGINAL +1 -1
@@ -9,7 +9,7 @@
     fi
 }
 
-if [ ! -e /sys$DEVPATH/loading ]; then
+if [ ! -e /sys/$DEVPATH/loading ]; then

Nope, $DEVPATH includes a leading slash.
But for consistency reasons I would say you could make a patch to remove the slash at the other uses of $DEVPATH in the file. ;)

Signature · 12 lines
Greetings Michael.


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel