let BT_HIDP depend on INPUT

PATCH In review Adrian Bunk 2 participants 3 messages Jul 10, 2006

Subsystems (4)

Networking Network drivers Bluetooth drivers Bluetooth

lore

Share & tools

lore

Adrian Bunk

author

2006-07-10 18:31 UTC #0 lore raw

PATCH 1/1 let BT_HIDP depend on INPUT

This patch let's BT_HIDP depend on instead of select INPUT.

This fixes the following warning during an s390 build:

<-- snip -->

...
net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol 'BT_HIDP' refer to undefined symbol 'INPUT'
...

<-- snip -->

A dependency on INPUT also implies !S390 (and therefore makes the explicit dependency obsolete) since INPUT is not available on s390.

The practical difference should be nearly zero, since INPUT is always set to y unless EMBEDDED=y (or S390=y).

Signed-off-by Adrian Bunk <[email protected]>

net/bluetooth/hidp/Kconfig renamed from net/bluetooth/hidp/Kconfig.old +1 -2

@@ -1,7 +1,6 @@
 config BT_HIDP
 	tristate "HIDP protocol support"
-	depends on BT && BT_L2CAP && (BROKEN || !S390)
-	select INPUT
+	depends on INPUT && BT && BT_L2CAP
 	help
 	  HIDP (Human Interface Device Protocol) is a transport layer
 	  for HID reports.  HIDP is required for the Bluetooth Human

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Marcel Holtmann

maintainer

2006-07-10 19:07 UTC #1 lore raw

Hi Adrian,

Quoted 10 lines

This patch let's BT_HIDP depend on instead of select INPUT.
This fixes the following warning during an s390 build:
<-- snip -->
...
net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol 'BT_HIDP' refer to undefined symbol 'INPUT'
...

Quoted 7 lines

<-- snip -->
A dependency on INPUT also implies !S390 (and therefore makes the explicit dependency obsolete) since INPUT is not available on s390.
The practical difference should be nearly zero, since INPUT is always set to y unless EMBEDDED=y (or S390=y).

I actually have no idea why we ended up with using select, but depends is also fine by me. Except I like to see it "BT && BT_L2CAP && INPUT" ;)

Regards

Marcel

Adrian Bunk

author

2006-07-10 19:33 UTC #2 lore raw

PATCH 1/1 let BT_HIDP depend on INPUT

Quoted 14 lines · Marcel Holtmann

Hi Adrian,
Quoted 12 lines
This patch let's BT_HIDP depend on instead of select INPUT.
This fixes the following warning during an s390 build:
<-- snip -->
...
net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol 'BT_HIDP' refer to undefined symbol 'INPUT'
...
<-- snip -->

Quoted 8 lines

Quoted 5 lines
A dependency on INPUT also implies !S390 (and therefore makes the explicit dependency obsolete) since INPUT is not available on s390.
The practical difference should be nearly zero, since INPUT is always set to y unless EMBEDDED=y (or S390=y).
I actually have no idea why we ended up with using select, but depends is also fine by me. Except I like to see it "BT && BT_L2CAP && INPUT" ;)

Updated patch below.

Quoted 3 lines

Regards
Marcel

cu
Adrian

<-- snip -->

This patch lets BT_HIDP depend on instead of select INPUT.

This fixes the following warning during an s390 build:

<-- snip -->

...
net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol 'BT_HIDP' r
efer to undefined symbol 'INPUT'
...

<-- snip -->

A dependency on INPUT also implies !S390 (and therefore makes the explicit dependency obsolete) since INPUT is not available on s390.

The practical difference should be nearly zero, since INPUT is always set to y unless EMBEDDED=y (or S390=y).

Signed-off-by Adrian Bunk <[email protected]>

net/bluetooth/hidp/Kconfig renamed from net/bluetooth/hidp/Kconfig.old +1 -2

@@ -1,7 +1,6 @@
 config BT_HIDP
 	tristate "HIDP protocol support"
-	depends on BT && BT_L2CAP && (BROKEN || !S390)
-	select INPUT
+	depends on BT && BT_L2CAP && INPUT
 	help
 	  HIDP (Human Interface Device Protocol) is a transport layer
 	  for HID reports.  HIDP is required for the Bluetooth Human