Skip to contentSkip to conversation

kobject: must_check fixes

PATCH New Randy.Dunlap 1 participant 1 message Jul 12, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kobject: must_check fixes

From: Randy Dunlap <[email protected]>

Check all __must_check warnings in lib/kobject.c

---
 lib/kobject.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletion(-)
lib/kobject.c +8 -1
@@ -457,6 +457,7 @@ static struct kobj_type dir_ktype = {
 struct kobject *kobject_add_dir(struct kobject *parent, const char *name)
 {
 	struct kobject *k;
+	int ret;
 
 	if (!parent)
 		return NULL;
@@ -468,7 +469,13 @@ struct kobject *kobject_add_dir(struct k
 	k->parent = parent;
 	k->ktype = &dir_ktype;
 	kobject_set_name(k, name);
-	kobject_register(k);
+	ret = kobject_register(k);
+	if (ret < 0) {
+		printk(KERN_WARNING "kobject_add_dir: "
+			"kobject_register error: %d\n", ret);
+		kobject_del(k);
+		return NULL;
+	}
 
 	return k;
 }

---