lockdep: fix false positive
Subsystems (2)
NETROM network devices are virtual network devices encapsulating NETROM frames into AX.25 which will be sent through an AX.25 device, so form a special "super class" of normal net devices; split their locks off into a separate class since they always nest.
--- net/netrom/af_netrom.c | 9 +++++++++ 1 file changed, 9 insertions(+)
net/netrom/af_netrom.c +9 -0
@@ -66,6 +66,14 @@ static DEFINE_SPINLOCK(nr_list_lock);static const struct proto_ops nr_proto_ops;/* +* NETROM network devices are virtual network devices encapsulating NETROM +* frames into AX.25 which will be sent through an AX.25 device, so form a +* special "super class" of normal net devices; split their locks off into a +* separate class since they always nest. +*/ +static struct lock_class_key nr_netdev_xmit_lock_key; + +/* * Socket removal during an interrupt is now safe. */ static void nr_remove_socket (struct sock *sk)
@@ -1405,6 +1413,7 @@ static int __init nr_proto_init(void)free_netdev (dev); goto fail; } +lockdep_set_class (&dev->_xmit_lock, &nr_netdev_xmit_lock_key); dev_nr[i] = dev; }
Ingo Molnar
Acked-byQuoted 6 lines · Ralf Baechle
NETROM network devices are virtual network devices encapsulating NETROM frames into AX.25 which will be sent through an AX.25 device, so form a special "super class" of normal net devices; split their locks off into a separate class since they always nest.
Signed-off-by Ralf Baechle <[email protected]>
thanks,
Ingo
From: Ralf Baechle <[email protected]>
Date: Tue, 11 Jul 2006 23:11:42 +0100
Quoted 6 lines
NETROM network devices are virtual network devices encapsulating NETROM frames into AX.25 which will be sent through an AX.25 device, so form a special "super class" of normal net devices; split their locks off into a separate class since they always nest.
Signed-off-by Ralf Baechle <[email protected]>
Applied, thanks.