bttv-driver.c:3964: error: void value not ignored as it ought to be
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 17 lines · Axel Thimm
latest hg fails on > 2.6.17 due to
video_device_create_filebeing void but still being asked for a return value inbttv-driver.c
linux/drivers/media/video/bt8xx/bttv-driver.c:3963 #if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,17) 3964 ret = video_device_create_file(btv->video_dev, &class_device_attr_card); 3965 if (ret < 0)
linux/include/media/v4l2-dev.h:379 static inline void
380 video_device_create_file(structvideo_device*vfd,
381 structclass_device_attribute*attr)
382 {
Quoted 8 lines
CC [M] /builddir/video4linux-20060717/v4l/flexcop-dma.o
CC [M] /builddir/video4linux-20060717/v4l/bttv-driver.o
/builddir/video4linux-20060717/v4l/bttv-driver.c: In function 'bttv_register_video':
/builddir/video4linux-20060717/v4l/bttv-driver.c:3964: error: void value not ignored as it ought to be /builddir/video4linux-20060717/v4l/bttv-driver.c: In function 'bttv_probe':
/builddir/video4linux-20060717/v4l/bttv-driver.c:4074: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'resource_size_t' /builddir/video4linux-20060717/v4l/bttv-driver.c:4086: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'resource_size_t' make[3]: *** [/builddir/video4linux-20060717/v4l/bttv-driver.o] Error 1
Hmmm... This was caused by the "Check all __must_check warnings in bttv." patch from Randy Dunlap (cc's from original thread added)
I am aware that this was done for various reasons of sanity checking, however, we cannot check the return value of a void ;-)
-Mike
Signature · 1 line
Michael Krufky
Quoted 18 lines · Michael Krufky
Quoted 17 lines · Axel Thimm
latest hg fails on > 2.6.17 due to
video_device_create_filebeing void but still being asked for a return value inbttv-driver.c
linux/drivers/media/video/bt8xx/bttv-driver.c:3963 #if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,17) 3964 ret = video_device_create_file(btv->video_dev, class_device_attr_card); 3965 if (ret < 0)
linux/include/media/v4l2-dev.h:379 static inline void
380 video_device_create_file(structvideo_device*vfd,
381 structclass_device_attribute*attr)
382 {
<snip>
Quoted 5 lines
Hmmm... This was caused by the "Check all
__must_checkwarnings in bttv." patch from Randy Dunlap (cc's from original thread added)I am aware that this was done for various reasons of sanity checking, however, we cannot check the return value of a void ;-)
For the sanity checking, I don't think video_device_create_file() should be a void function. It probably should return class_device_create_file()'s return value, no? As it can fail...
Thanks,
Nish
Quoted 26 lines · Nish Aravamudan
Quoted 19 lines · Michael Krufky
Quoted 7 lines · Axel Thimm
latest hg fails on > 2.6.17 due to
video_device_create_filebeing void but still being asked for a return value inbttv-driver.c
linux/drivers/media/video/bt8xx/bttv-driver.c:3963 #if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,17) 3964 ret = video_device_create_file(btv->video_dev,
class_device_attr_card);Quoted 10 lines
3965 if (ret < 0)
linux/include/media/v4l2-dev.h:379 static inline void
380 video_device_create_file(structvideo_device*vfd,
381 structclass_device_attribute*attr)
382 {<snip>
Quoted 3 lines
Hmmm... This was caused by the "Check all
__must_checkwarnings in bttv." patch from Randy Dunlap (cc's from original thread added)
Quoted 7 lines
Quoted 2 lines
I am aware that this was done for various reasons of sanity checking, however, we cannot check the return value of a void ;-)
For the sanity checking, I don't think
video_device_create_file()should be a void function. It probably should return class_device_create_file()'s return value, no? As it can fail...
You are correct... I was merely pointing out the error, but now I see it runs deeper than I had thought. I will fix both video_device_create_file and video_device_remove_file to return the class_device_foo return values, then I'll push it over to Mauro.
Cheers,
Michael Krufky
Quoted 12 lines · Michael Krufky
Quoted 10 lines · Nish Aravamudan
Quoted 5 lines · Michael Krufky
Hmmm... This was caused by the "Check all
__must_checkwarnings in bttv." patch from Randy Dunlap (cc's from original thread added)I am aware that this was done for various reasons of sanity checking, however, we cannot check the return value of a void ;-)
For the sanity checking, I don't think
video_device_create_file()should be a void function. It probably should return class_device_create_file()'s return value, no? As it can fail...
Quoted 4 lines
You are correct... I was merely pointing out the error, but now I see it runs deeper than I had thought. I will fix both
video_device_create_fileandvideo_device_remove_fileto return theclass_device_fooreturn values, then I'll push it over to Mauro.
I was in a rush when I wrote that, and I wasn't thinking. video_device_remove_file stays as a void.
Anyway, here is the fix. This is already in my tree ( http://linuxtv.org/hg/~mkrufky/v4l-dvb ) but split into separate patches.
no s-o-b needed for now -- this will come up through Mauro.
linux/drivers/media/video/bt8xx/bttv-driver.c 2006-07-17 21:55:54.000000000 -0400 renamed from linux/drivers/media/video/bt8xx/bttv-driver.c 2006-07-17 22:57:05.000000000 -0400 +0 -11
@@ -3942,10 +3942,6 @@ static void bttv_unregister_video(struct /* register video4linux devices */ static int __devinit bttv_register_video(struct bttv *btv) { -#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,17) - int ret; -#endif - if (no_overlay <= 0) { bttv_video_template.type |= VID_TYPE_OVERLAY; } else {
@@ -3960,17 +3956,10 @@ static int __devinit bttv_register_video goto err; printk(KERN_INFO "bttv%d: registered device video%d\n", btv->c.nr,btv->video_dev->minor & 0x1f); -#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,17) - ret = video_device_create_file(btv->video_dev, &class_device_attr_card); - if (ret < 0) - printk(KERN_WARNING "bttv: video_device_create_file error: " - "%d\n", ret); -#else #if LINUX_VERSION_CODE > KERNEL_VERSION(2,5,0) video_device_create_file(btv->video_dev, &class_device_attr_card); #endif -#endif /* vbi */ btv->vbi_dev = vdev_init(btv, &bttv_vbi_template, "vbi");
linux/include/media/v4l2-dev.h 2006-07-17 22:34:32.000000000 -0400 renamed from linux/include/media/v4l2-dev.h 2006-07-17 22:57:06.000000000 -0400 +0 -0
@@ -376,11 +376,14 @@ extern struct video_device* video_devdat #if LINUX_VERSION_CODE > KERNEL_VERSION(2,5,0) #define to_video_device(cd) container_of(cd, struct video_device,
class_dev)
-static inline void
+static inline int
video_device_create_file(struct video_device *vfd,
struct class_device_attribute *attr)
{
- class_device_create_file(&vfd->class_dev, attr); + int ret = class_device_create_file(&vfd->class_dev, attr); + if (ret < 0)
+ printk(KERN_WARNING "%s error: %d\n", __FUNCTION__, ret);
+ return ret;
}
static inline void video_device_remove_file(struct video_device *vfd,