Skip to contentSkip to conversation

i386: show_registers(): try harder to print failing code

PATCH Chuck Ebbert 2 participants 2 messages Jul 19, 2006

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Quoted 11 lines · Jesper Juhl
Quoted 8 lines

show_registers() tries to dump failing code starting 43 bytes before the offending instruction, but this address can be bad, for example in a device driver where the failing instruction is less than 43 bytes from the start of the driver's code. When that happens, try to dump code starting at the failing instruction instead of printing no code at all.

Shouldn't the kernel be printing some info noting that this fallback is in use then? Or will that be completely obvious and I'm just not able to see that?

The code byte at EIP is marked with '<>', so it's obvious:

Code: <a1> 00 00 00 00 c7 04 24 05 30 b5 de 89 44 24 04 e8 f5 6f 5c e1 c9 31 c0 c3 00 00 00 00 00 00 00
Signature · 1 line
Chuck
#1 lore raw
Quoted 11 lines · Chuck Ebbert

In-Reply-To: <[email protected]>

Quoted 8 lines · Jesper Juhl
Quoted 8 lines

show_registers() tries to dump failing code starting 43 bytes before the offending instruction, but this address can be bad, for example in a device driver where the failing instruction is less than 43 bytes from the start of the driver's code. When that happens, try to dump code starting at the failing instruction instead of printing no code at all.

Quoted 8 lines
Quoted 3 lines

Shouldn't the kernel be printing some info noting that this fallback is in use then? Or will that be completely obvious and I'm just not able to see that?

The code byte at EIP is marked with '<>', so it's obvious:

Code: <a1> 00 00 00 00 c7 04 24 05 30 b5 de 89 44 24 04 e8 f5 6f 5c e1 c9 31 c0 c3 00 00 00 00 00 00 00

Ahh, ok. I was not aware of that. Thank you for the info.

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html