Debugging APM - cat /proc/apm produces oops
Hello,
cat /proc/apm produces oops on my DTK notebook. Using "apm=broken-psr" kernel parameter fixes that but I lose the battery info. I'd like to have the battery info (and it works fine in Windows) so I want to debug it and (hopefully) fix.
The oops:
# cat /proc/apm
<1>BUG: unable to handle kernel paging request at virtual address 00005e88
printing eip:
00002f9d
*pre = 00000000
Oops: 0002 [#4]
Modules linked in:
CPU: 0
EIP: 00c0:[<00002f9d>] Not tainted VLI
EFLAGS: 00010017 (2.6.17-5-dtk #23)
EIP is at 0x2f94
eax: 00000033 ebx: 00000001 ecx: 00000000 edx: 00000000
esi: c10a1000 edi: 00000014 ebp: c4755e8a esp: c4755e88
ds: 00c8 es: 0000 ss: 0068
Process cat (pid: 1928, threadinfo=c4754000 task=c11240b0)
Stack: 5e948001 5fc75e55 00005e94 000000c8 10000033 5ea800c0 00000001 530a0000
00000016 00b86017 00000000 0000530a c010830f 00000060 0000530a 00000033
0000007b 0000007b c0337368 00000000 c10a1000 00000000 00000000 00000282
Call Trace:
<c010830f> apm_bios_call+0x68/0xba <c0108728> apm_get_power_status+0x44/0x90
<c01091a0> apm_get_info+0x34/0xdc <c01617dc> proc_file_read+0xda/0x22d
<c013b5a2> vfs_read+0x82/0x10e <c013b873> sys_read+0x3c/0x62
<c0102397> syscall_call+0x7/0xb
Code: Bad EIP value.
EIP: [<00002f9d>] 0x2f9d SS:ESP 0068:c4755e88So it looks like it dies somewhere in the APM BIOS code. But how to find exactly where and/or why? Maybe use GDB somehow (I've used it only for really simple debugging yet).
I've tried calling the APM 0x530A function from DOS (real mode, int 15h) and single-stepping the BIOS APM code (using good old user-friendly Turbo Debugger). Noticed some OUTs to 0xB1 (or something like that), then some PCI accesses (0xCF8 and 0xCFC) and then IP ended in area of all zeros. When I step over the int 15h call, it works fine - returns correct info.
Signature · 1 line
Ondrej Zary
Quoted 5 lines · Ondrej Zary
I've tried calling the APM
0x530Afunction from DOS (real mode, int 15h) and single-stepping the BIOS APM code (using good old user-friendly Turbo Debugger). Noticed some OUTs to0xB1(or something like that), then some PCI accesses (0xCF8and0xCFC) and then IP ended in area of all zeros. When I step over the int 15h call, it works fine - returns correct info.
Sorry, this was my bad. It works fine even when single stepping. I've made a mistake and stepped over the ending int 20h instruction of my .com program...
I'm probably going to write down complete sequence of instructions which get executed during the call.
Signature · 1 line
Ondrej Zary
Quoted 5 lines · On Sun, 23 Jul 2006 16:30:53 +0200 Ondrej Zary <[email protected]>…
cat
/proc/apmproduces oops on my DTK notebook. Using "apm=broken-psr" kernel parameter fixes that but I lose the battery info. I'd like to have the battery info (and it works fine in Windows) so I want to debug it and (hopefully) fix.
Is there some reason you can't (or don't want to) use ACPI on this machine?
Quoted 3 lines
The oops:
# cat /proc/apm <1>BUG: unable to handle kernel paging request at virtual address 00005e88
^^^^
Looks like it tried to access through the stack pointer while executeing 16 bit code.
Quoted 7 lines
printing eip:
00002f9d
*pre = 00000000Oops: 0002 [#4] Modules linked in: CPU: 0 EIP: 00c0:[<00002f9d>] Not tainted VLI
^^^^
This is the APM BIOS 16 bit code segment.
Quoted 4 lines
EFLAGS: 00010017 (2.6.17-5-dtk #23)
EIP is at0x2f94
eax: 00000033 ebx: 00000001 ecx: 00000000 edx: 00000000
esi:c10a1000edi: 00000014 ebp:c4755e8aesp:c4755e88
^^^^
Accessing the stack while executing 16 bit code is never going to work.
Quoted 13 lines
ds: 00c8 es: 0000 ss: 0068
Process cat (pid: 1928, threadinfo=c4754000 task=c11240b0)Stack: 5e948001 5fc75e55 00005e94 000000c8 10000033 5ea800c0 00000001 530a0000 00000016 00b86017 00000000 0000530a c010830f 00000060 0000530a 00000033 0000007b 0000007b c0337368 00000000 c10a1000 00000000 00000000 00000282 Call Trace: <c010830f> apm_bios_call+0x68/0xba <c0108728> apm_get_power_status+0x44/0x90 <c01091a0> apm_get_info+0x34/0xdc <c01617dc> proc_file_read+0xda/0x22d <c013b5a2> vfs_read+0x82/0x10e <c013b873> sys_read+0x3c/0x62 <c0102397> syscall_call+0x7/0xb Code: Bad EIP value.EIP: [<
00002f9d>]0x2f9dSS:ESP 0068:c4755e88
Quoted 8 lines
So it looks like it dies somewhere in the APM BIOS code. But how to find exactly where and/or why? Maybe use GDB somehow (I've used it only for really simple debugging yet).
I've tried calling the APM0x530Afunction from DOS (real mode, int 15h) and single-stepping the BIOS APM code (using good old user-friendly Turbo Debugger). Noticed some OUTs to0xB1(or something like that), then some PCI accesses (0xCF8and0xCFC) and then IP ended in area of all zeros. When I step over the int 15h call, it works fine - returns correct info.
APM BIOS's are often only tested in real mode as that will suffice for older Windows systems. If you machine is less than 6 years old, Windows is almost certainly using ACPI and not APM.
If you really want this fixedm you will have to talk to your machine menufacturer (or the BIOS manufacturer).
Signature · 3 lines
Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Quoted 1 line · you
On Sun, 23 Jul 2006 16:30:53 +0200 Ondrej Zary <[email protected]>
Quoted 6 lines · wrote:
Quoted 4 lines
cat
/proc/apmproduces oops on my DTK notebook. Using "apm=broken-psr" kernel parameter fixes that but I lose the battery info. I'd like to have the battery info (and it works fine in Windows) so I want to debug it and (hopefully) fix.Is there some reason you can't (or don't want to) use ACPI on this machine?
The machine is old (1997) and even the latest BIOS (1999) does not support ACPI (although the i430TX chipset itself is ACPI-compatible).
Quoted 9 lines
Quoted 5 lines
The oops:
# cat /proc/apm <1>BUG: unable to handle kernel paging request at virtual address 00005e88^^^^ Looks like it tried to access through the stack pointer while executeing 16 bit code.
Thanks for explanation.
Quoted 43 lines
Quoted 8 lines
printing eip:
00002f9d
*pre = 00000000Oops: 0002 [#4] Modules linked in: CPU: 0 EIP: 00c0:[<00002f9d>] Not tainted VLI^^^^This is the APM BIOS 16 bit code segment.
Quoted 4 lines
EFLAGS: 00010017 (2.6.17-5-dtk #23)
EIP is at0x2f94
eax: 00000033 ebx: 00000001 ecx: 00000000 edx: 00000000
esi:c10a1000edi: 00000014 ebp:c4755e8aesp:c4755e88^^^^Accessing the stack while executing 16 bit code is never going to work.
Quoted 14 lines
ds: 00c8 es: 0000 ss: 0068
Process cat (pid: 1928, threadinfo=c4754000 task=c11240b0)Stack: 5e948001 5fc75e55 00005e94 000000c8 10000033 5ea800c0 00000001
530a00000000001600b86017000000000000530ac010830f000000600000530a000000330000007b0000007bc033736800000000c10a100000000000 00000000 00000282 Call Trace:
<c010830f>apm_bios_call+0x68/0xba<c0108728>apm_get_power_status+0x44/0x90 <c01091a0> apm_get_info+0x34/0xdc <c01617dc> proc_file_read+0xda/0x22d <c013b5a2> vfs_read+0x82/0x10e <c013b873> sys_read+0x3c/0x62 <c0102397> syscall_call+0x7/0xb Code: Bad EIP value.EIP: [<
00002f9d>]0x2f9dSS:ESP 0068:c4755e88Quoted 8 lines
So it looks like it dies somewhere in the APM BIOS code. But how to find exactly where and/or why? Maybe use GDB somehow (I've used it only for really simple debugging yet).
I've tried calling the APM0x530Afunction from DOS (real mode, int 15h) and single-stepping the BIOS APM code (using good old user-friendly Turbo Debugger). Noticed some OUTs to0xB1(or something like that), then some PCI accesses (0xCF8and0xCFC) and then IP ended in area of all zeros. When I step over the int 15h call, it works fine - returns correct info.
Quoted 6 lines
APM BIOS's are often only tested in real mode as that will suffice for older Windows systems. If you machine is less than 6 years old, Windows is almost certainly using ACPI and not APM.
If you really want this fixedm you will have to talk to your machine menufacturer (or the BIOS manufacturer).
This is not going to work as it's not supported anymore :(
Too bad that the BIOS is Phoenix, as I'm able to modify Award BIOSes only. So I'll try to find out what the APM BIOS does, rewrite it in C and put in my kernel.
Signature · 1 line
Ondrej Zary
Quoted 1 line · Stephen Rothwell
On Sun, 23 Jul 2006 16:30:53 +0200 Ondrej Zary <[email protected]>
Quoted 10 lines · wrote:
Quoted 7 lines
printing eip:
00002f9d
*pre = 00000000Oops: 0002 [#4] Modules linked in: CPU: 0 EIP: 00c0:[<00002f9d>] Not tainted VLI^^^^This is the APM BIOS 16 bit code segment.
Looking at BIOS disassembly:
2F97: push bp
2F98: mov bp,sp
2F9A: add sp,-2
2F9D: mov [bp][-2],bx <-- it oopses here
I realized that I can modify the BIOS easily as it's stored in shadow RAM. So I replaced the offending MOV with three NOPs and tested again. This time it oopsed at 0x2FAD:
2FAD: cmp w,[bp][-2],1
2FB1: je 2FCB
that jump was taken during my single stepping, so I NOPped out the CMP and replaced JE with JMPS. Then booted Linux and APM seems to work fine - battery percentage and remaining time is there as well as AC power status. There seems to be 4 these operations:
mov [bp][-2],bx
cmp w,[bp][-2],1
cmp w,[bp][-2],8002
cmp w,[bp][-2],8001
but I've hit only the first two of them. I wonder what's that for (especially when it works without that).
Signature · 1 line
Ondrej Zary
Quoted 5 lines · Ondrej Zary
Hello,
cat/proc/apmproduces oops on my DTK notebook. Using "apm=broken-psr" kernel parameter fixes that but I lose the battery info. I'd like to have the battery info (and it works fine in Windows) so I want to debug it and (hopefully) fix.
If broken-psr is needed can you also send me a dmidecode and lspci -vxx dump so I can automate that bit.
Alan
This is my "fix" - patches BIOS in shadow RAM. Ugly but allows me to use APM battery status. Probably not worth including in the kernel but it might help someone...
drivers/pci/quirks.c +30 -0
@@ -1404,6 +1404,36 @@ }DECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_NCR ,PCI_DEVICE_ID_NCR_53C810 , fixup_rev1_53c810); +#ifdef CONFIG_X86 +/* +* Fix DTK FortisPro TOP-5A APM BIOS bug which causes oops on /proc/apm access +* Most probably works only with the latest BIOS rev 2.31 +*/ +static void __devinit quirk_dtk_top5a (struct pci_dev *dev) +{ +u8 *patch_addr_1 =__va (0xf2f9d ); +u8 orig_1[] = {0x89 ,0x5e ,0xfe };/* mov [bp-2],bx -> this causes oops */ +u8 patch_1[] = {0x90 ,0x90 ,0x90 };/* 3x nop */ +u8 *patch_addr_2 =__va (0xf2fad ); +u8 orig_2[] = {0x83 ,0x7e ,0xfe ,0x01 ,/* cmp w,[bp-2],1 -> second oops */ +0x74 };/* je somewhere -> this must be changed to jmps */ +u8 patch_2[] = {0x90 ,0x90 ,0x90 ,0x90 ,0xeb };/* 4x nop + jmps */ +u8 shadow_cfg; + +/* Check if it's the buggy BIOS */ +if (memcmp (patch_addr_1, &orig_1[0 ],ARRAY_SIZE (orig_1)) || +memcmp (patch_addr_2, &orig_2[0 ],ARRAY_SIZE (orig_2))) +return ; + +printk (KERN_INFO "Fixing DTK FortisPro TOP-5A APM BIOS bug\n" ); +pci_read_config_byte (dev,0x59 , &shadow_cfg); +pci_write_config_byte (dev,0x59 ,0x20 );/* enable shadow BIOS writes */ +memcpy (patch_addr_1, patch_1,ARRAY_SIZE (patch_1)); +memcpy (patch_addr_2, patch_2,ARRAY_SIZE (patch_2)); +pci_write_config_byte (dev,0x59 , shadow_cfg); +} +DECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82439TX , quirk_dtk_top5a); +#endif /* CONFIG_X86 */ static void pci_do_fixups (struct pci_dev *dev,struct pci_fixup *f,struct pci_fixup *end) {
Signature · 1 line
Ondrej Zary
Quoted 9 lines · Alan Cox
Quoted 5 lines · Ondrej Zary
Hello,
cat/proc/apmproduces oops on my DTK notebook. Using "apm=broken-psr" kernel parameter fixes that but I lose the battery info. I'd like to have the battery info (and it works fine in Windows) so I want to debug it and (hopefully) fix.If broken-psr is needed can you also send me a dmidecode and lspci -vxx dump so I can automate that bit.
I just found that there is another problem with this machine - DMI :) Both kernel and dmidecode says that the DMI is not present - so one would say that the BIOS does not support DMI.
But wait... HWiNFO32 for DOS shows working DMI 2.0 with real data (although some data is from Intel Trajan reference board, apparently not changed by BIOS engineer...)
Examining $F000 BIOS segment revealed that the "_DMI_" signature is not present. But there is "_DMI20_" - and the header does not seem to match. I can see all the strings (like "Trajan") there...
Anyone interested in BIOS dump?
Signature · 1 line
Ondrej Zary