Skip to contentSkip to conversation

x86: rename is_at_popf(), add iret to tests and fix insn length

PATCH Chuck Ebbert 2 participants 2 messages Aug 2, 2006

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Quoted 5 lines · On Wed, 2 Aug 2006 14:54:33 +0200. Andi Kleen wrote:
Quoted 2 lines

is_at_popf() needs to test for the iret instruction as well as popf. So add that test and rename it to is_setting_trap_flag().

Do you have a single real example where anybody is actually using IRET in user space?

No, but Albert Cahalan complained so I figured it should be fixed.

Signature · 1 line
Chuck
#1 lore raw
Quoted 11 lines · Chuck Ebbert

In-Reply-To: <[email protected]>

Quoted 5 lines · On Wed, 2 Aug 2006 14:54:33 +0200. Andi Kleen wrote:
Quoted 2 lines

is_at_popf() needs to test for the iret instruction as well as popf. So add that test and rename it to is_setting_trap_flag().

Do you have a single real example where anybody is actually using IRET in user space?

No, but Albert Cahalan complained so I figured it should be fixed.

I suppose he just collected all the obscure FIXMEs in the code he could find. Ok I merged it, but only because it is so little code.

-Andi