Skip to contentSkip to conversation

s390: lost interrupt after chpid vary off/on cycle.

PATCH New Martin Schwidefsky 1 participant 1 message Aug 7, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390: lost interrupt after chpid vary off/on cycle.

From: Peter Oberparleiter <[email protected]>

[S390] lost interrupt after chpid vary off/on cycle.

I/O on a CCW device may stall if a channel path to that device is logicaly varied off/on. A user I/O interrupt can get misinterpreted as interrupt for an internal path verification operation due to a missing check and is therefore never reported to the device driver.

Correct check for pending interruptions before starting path verification.

---

 drivers/s390/cio/device_fsm.c |    1 +
 1 files changed, 1 insertion(+)
drivers/s390/cio/device_fsm.c +1 -0
diff -urpN linux-2.6/drivers/s390/cio/device_fsm.c linux-2.6-patched/drivers/s390/cio/device_fsm.c
@@ -772,6 +772,7 @@ ccw_device_online_verify(struct ccw_devi
 	stsch(sch->schid, &sch->schib);
 
 	if (sch->schib.scsw.actl != 0 ||
+	    (sch->schib.scsw.stctl & SCSW_STCTL_STATUS_PEND) ||
 	    (cdev->private->irb.scsw.stctl & SCSW_STCTL_STATUS_PEND)) {
 		/*
 		 * No final status yet or final status not yet delivered