Skip to contentSkip to conversation

drivers/media/dvb/dvb-usb/dibusb-mb.c: NULL dereference

DISCUSSION Adrian Bunk 2 participants 2 messages Aug 14, 2006 – Aug 15, 2006

lore
Share & tools
lore
#0 lore raw

The Coverity checker spotted the following "we dereference d->fe only when we know it's NULL" bug:

<-- snip -->

...
static int dibusb_dib3000mb_frontend_attach(struct dvb_usb_device *d) {
...

        if ((d->fe = dib3000mb_attach(&demod_cfg,&d->i2c_adap,&st->ops)) == NULL) {
                d->fe->ops.tuner_ops.init = dvb_usb_tuner_init_i2c;
                d->fe->ops.tuner_ops.set_params = dvb_usb_tuner_set_params_i2c;
                return -ENODEV;
        }

...

<-- snip -->

cu
Adrian

Signature · 6 lines
    Gentoo kernels are 42 times more popular than SUSE kernels among
    KLive users  (a service by SUSE contractor Andrea Arcangeli that
    gathers data about kernels from many users worldwide).

       There are three kinds of lies: Lies, Damn Lies, and Statistics.
                                                    Benjamin Disraeli
#1 lore raw

Hi Adrian,

Quoted 9 lines · Adrian Bunk

The Coverity checker spotted the following "we dereference d->fe only when we know it's NULL" bug:

<-- snip -->

...
static int dibusb_dib3000mb_frontend_attach(struct dvb_usb_device *d) {
...

Quoted 8 lines
        if ((d->fe = dib3000mb_attach(&demod_cfg,&d->i2c_adap,&st->ops)) == NULL) {
                d->fe->ops.tuner_ops.init = dvb_usb_tuner_init_i2c;
                d->fe->ops.tuner_ops.set_params = dvb_usb_tuner_set_params_i2c;
                return -ENODEV;
        }

...

<-- snip -->

Oops, this one was introduced in rev 3124 of the v4l-dvb repository when adding tuner_ops.

Mauro, can you please pull from http://linuxtv.org/hg/~pb/v4l-dvb to get the fix.

For the others: the changeset is here:

http://linuxtv.org/hg/~pb/v4l-dvb?cmd=changeset;node=ac1c589c56fc018f14fdf74c274d8438a8566b69;style=raw

regards,
Patrick.

--
Mail: [email protected]
WWW: http://www.wi-bw.tfh-wildau.de/~pboettch/