Skip to contentSkip to conversation

drivers/crypto/geode-aes.c: cleanups

PATCH New Adrian Bunk 1 participant 1 message Aug 15, 2006

Subsystems (2)
Crypto API AMD geode processor/chipset support
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 drivers/crypto/geode-aes.c: cleanups

This patch contains the following cleanups:
- make needlessly global code static
- use C99 struct initializers

Signed-off-by Adrian Bunk <[email protected]>

---

The {cia,geode_aes}_{setkey,encrypt,decryt} prototype confusion both sparse and gcc are giveng warnings about should also be fixed.

This patch was already sent on:
- 7 Aug 2006

 drivers/crypto/geode-aes.c |   12 ++++++------
 drivers/crypto/geode-aes.h |    2 --
 2 files changed, 6 insertions(+), 8 deletions(-)
drivers/crypto/geode-aes.h renamed from drivers/crypto/geode-aes.h.old +0 -2
@@ -37,6 +37,4 @@
   u8 iv[AES_IV_LENGTH];
 };
 
-unsigned int geode_aes_crypt(struct geode_aes_op *);
-
 #endif
drivers/crypto/geode-aes.c renamed from drivers/crypto/geode-aes.c.old +6 -6
@@ -114,7 +114,7 @@
 	AWRITE((status & 0xFF) | AES_INTRA_PENDING, AES_INTR_REG);
 }
 
-unsigned int
+static unsigned int
 geode_aes_crypt(struct geode_aes_op *op)
 {
 	u32 flags = 0;

@@ -361,7 +361,7 @@
 	return ret;
 }
 
-struct pci_device_id geode_aes_tbl[] = {
+static struct pci_device_id geode_aes_tbl[] = {
 	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_LX_AES, PCI_ANY_ID, PCI_ANY_ID} ,
 	{ 0, }
 };

@@ -369,10 +369,10 @@
 MODULE_DEVICE_TABLE(pci, geode_aes_tbl);
 
 static struct pci_driver geode_aes_driver = {
-	name:      "Geode LX AES",
-	id_table:  geode_aes_tbl,
-	probe:     geode_aes_probe,
-	remove:    __devexit_p(geode_aes_remove)
+	.name		= "Geode LX AES",
+	.id_table	= geode_aes_tbl,
+	.probe		= geode_aes_probe,
+	.remove		= __devexit_p(geode_aes_remove)
 };
 
 static int __devinit