Skip to contentSkip to conversation

ieee80211: Add IEEE80211_API_VERSION macro

PATCH NAK Zhu Yi 3 participants 4 messages Aug 21, 2006 – Aug 22, 2006

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Zhu Yi

author
#0 lore raw

PATCH 4/7 ieee80211: Add IEEE80211_API_VERSION macro

Add IEEE80211_API_VERSION macro so that drivers are able to check it during compile time. This feature is useful to make backward IEEE80211 compatibilities for wireless drivers.

Signed-off-by Zhu Yi <[email protected]>

---

 include/net/ieee80211.h |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

29be0803256136011dd5c3b62e3eb9f782e57dbd

include/net/ieee80211.h +11 -1
index b174ebb..83e06aa 100644
@@ -29,7 +29,17 @@
 #include <linux/kernel.h>	/* ARRAY_SIZE */
 #include <linux/wireless.h>
 
-#define IEEE80211_VERSION "git-1.1.13"
+#define IEEE80211_VERSION_MAJOR 1
+#define IEEE80211_VERSION_API 2
+#define IEEE80211_VERSION_MINOR 15
+#define IEEE80211_VERSION_CODE IEEE80211_VERSION_MAJOR * 65536 + \
+			       IEEE80211_VERSION_API * 256 + \
+			       IEEE80211_VERSION_MINOR
+#define _STRX(x) #x
+#define _VERSION_STR(a,b,c) _STRX(a) "." _STRX(b) "." _STRX(c)
+#define IEEE80211_VERSION _VERSION_STR(IEEE80211_VERSION_MAJOR,\
+				       IEEE80211_VERSION_API, \
+				       IEEE80211_VERSION_MINOR)
 
 #define IEEE80211_DATA_LEN		2304
 /* Maximum size for the MA-UNITDATA primitive, 802.11 standard section
Signature · 1 line
1.2.6
#1 lore raw
Quoted 3 lines · Zhu Yi

Add IEEE80211_API_VERSION macro so that drivers are able to check it during compile time. This feature is useful to make backward IEEE80211 compatibilities for wireless drivers.

Per my other mail, what exactly has changed and must be checked? The SIOCGIWFREQ stuff?

Dan

Quoted 31 lines
Signed-off-by Zhu Yi <[email protected]>

---

 include/net/ieee80211.h |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

29be0803256136011dd5c3b62e3eb9f782e57dbd

include/net/ieee80211.h +11 -1
index b174ebb..83e06aa 100644
@@ -29,7 +29,17 @@
 #include <linux/kernel.h>	/* ARRAY_SIZE */
 #include <linux/wireless.h>
 
-#define IEEE80211_VERSION "git-1.1.13"
+#define IEEE80211_VERSION_MAJOR 1
+#define IEEE80211_VERSION_API 2
+#define IEEE80211_VERSION_MINOR 15
+#define IEEE80211_VERSION_CODE IEEE80211_VERSION_MAJOR * 65536 + \
+			       IEEE80211_VERSION_API * 256 + \
+			       IEEE80211_VERSION_MINOR
+#define _STRX(x) #x
+#define _VERSION_STR(a,b,c) _STRX(a) "." _STRX(b) "." _STRX(c)
+#define IEEE80211_VERSION _VERSION_STR(IEEE80211_VERSION_MAJOR,\
+				       IEEE80211_VERSION_API, \
+				       IEEE80211_VERSION_MINOR)
 
 #define IEEE80211_DATA_LEN		2304
 /* Maximum size for the MA-UNITDATA primitive, 802.11 standard section
NAK
#3 lore raw
In reply to Zhu Yi
Quoted 3 lines · Zhu Yi

Add IEEE80211_API_VERSION macro so that drivers are able to check it during compile time. This feature is useful to make backward IEEE80211 compatibilities for wireless drivers.

NACK.

author
#2 lore raw
In reply to Dan Williams
Quoted 2 lines · Dan Williams

Per my other mail, what exactly has changed and must be checked? The SIOCGIWFREQ stuff?

The prototype of ieee80211_tx_frame() changed. It used to have 3 parameters. Now it has 5.

Thanks,
-yi