Skip to contentSkip to conversation

ieee80211: export symbol ieee80211_api_version

PATCH NAK Zhu Yi 4 participants 4 messages Aug 21, 2006

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Zhu Yi

author
#0 lore raw

PATCH 5/7 ieee80211: export symbol ieee80211_api_version

Export this symbol so that wireless drivers can check the running IEEE80211 API version dynamically.

Signed-off-by Zhu Yi <[email protected]>

---

 include/net/ieee80211.h          |    2 ++
 net/ieee80211/ieee80211_module.c |    3 +++
 2 files changed, 5 insertions(+), 0 deletions(-)

81634e488965fae232027e14a54c998ccb5b0c49

include/net/ieee80211.h +2 -0
index 83e06aa..ee66681 100644
@@ -1255,6 +1255,8 @@ static inline int ieee80211_is_cck_rate(
 	return 0;
 }
 
+extern const int ieee80211_api_version;
+
 /* ieee80211.c */
 extern void free_ieee80211(struct net_device *dev);
 extern struct net_device *alloc_ieee80211(int sizeof_priv);
net/ieee80211/ieee80211_module.c +3 -0
index 13b1e5f..02e730b 100644
@@ -61,6 +61,9 @@ MODULE_DESCRIPTION(DRV_DESCRIPTION);
 MODULE_AUTHOR(DRV_COPYRIGHT);
 MODULE_LICENSE("GPL");
 
+const int ieee80211_api_version = IEEE80211_VERSION_API;
+EXPORT_SYMBOL(ieee80211_api_version);
+
 static int ieee80211_networks_allocate(struct ieee80211_device *ieee)
 {
 	if (ieee->networks)
Signature · 1 line
1.2.6
#1 lore raw
Quoted 2 lines · Zhu Yi

Export this symbol so that wireless drivers can check the running IEEE80211 API version dynamically.

NACK (Or should I say no f***ing way :)). We don't export runtime subsystem versions, especially as they are totally useless already. Please submit a patch to remove the already meaningless net/ieee80211/ versioning instead.

#2 lore raw
In reply to Zhu Yi
Quoted 2 lines · Zhu Yi

Export this symbol so that wireless drivers can check the running IEEE80211 API version dynamically.

What's that needed for? Capability checks? Checking user's version to ensure they have a version with security fixes?

What API bits changed?

Dan

Quoted 36 lines
Signed-off-by Zhu Yi <[email protected]>

---

 include/net/ieee80211.h          |    2 ++
 net/ieee80211/ieee80211_module.c |    3 +++
 2 files changed, 5 insertions(+), 0 deletions(-)

81634e488965fae232027e14a54c998ccb5b0c49

include/net/ieee80211.h +2 -0
index 83e06aa..ee66681 100644
@@ -1255,6 +1255,8 @@ static inline int ieee80211_is_cck_rate(
 	return 0;
 }
 
+extern const int ieee80211_api_version;
+
 /* ieee80211.c */
 extern void free_ieee80211(struct net_device *dev);
 extern struct net_device *alloc_ieee80211(int sizeof_priv);
net/ieee80211/ieee80211_module.c +3 -0
index 13b1e5f..02e730b 100644
@@ -61,6 +61,9 @@ MODULE_DESCRIPTION(DRV_DESCRIPTION);
 MODULE_AUTHOR(DRV_COPYRIGHT);
 MODULE_LICENSE("GPL");
 
+const int ieee80211_api_version = IEEE80211_VERSION_API;
+EXPORT_SYMBOL(ieee80211_api_version);
+
 static int ieee80211_networks_allocate(struct ieee80211_device *ieee)
 {
 	if (ieee->networks)
#3 lore raw
In reply to Zhu Yi
Quoted 2 lines · Zhu Yi

Export this symbol so that wireless drivers can check the running IEEE80211 API version dynamically.

The sole purpose of this would seem to be supporting out-of-stream driver development. Is there some other use that I am overlooking?

I'm sorry, but we just can't/won't take patches that exist solely for that. A much better would be for ongoing driver development to be conducted solely upstream.

John

Signature · 2 lines
John W. Linville
[email protected]