Skip to contentSkip to conversation

ipw2100: Make ipw2100 depends on known working platforms

PATCH In review Zhu Yi 2 participants 4 messages Aug 21, 2006 – Aug 22, 2006

Subsystems (3)
lore
Share & tools
lore

Zhu Yi

author
#0 lore raw

PATCH 6/14 ipw2100: Make ipw2100 depends on known working platforms

ipw2100 driver doesn't support big endian by now.

---

 drivers/net/wireless/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

97b35942893f7999dadcd18d8801ac460f65ce67

drivers/net/wireless/Kconfig +1 -1
index a8ffd78..513bfc3 100644
@@ -146,7 +146,7 @@ comment "Wireless 802.11b ISA/PCI cards 
 
 config IPW2100
 	tristate "Intel PRO/Wireless 2100 Network Connection"
-	depends on NET_RADIO && PCI
+	depends on NET_RADIO && PCI && (X86 || X86_64 || IA64 || BROKEN)
 	select FW_LOADER
 	select IEEE80211
 	---help---
Signature · 1 line
1.2.6
#1 lore raw
Quoted 1 line · Zhu Yi

ipw2100 driver doesn't support big endian by now.

NACK. Fix it instead.

drivers/net/wireless/Kconfig comment "Wireless 802.11b ISA/PCI cards · line 149

Quoted 3 lines
drivers/net/wireless/Kconfig +1 -1
 	tristate "Intel PRO/Wireless 2100 Network Connection"
-	depends on NET_RADIO && PCI
+	depends on NET_RADIO && PCI && (X86 || X86_64 || IA64 || BROKEN)

There's a lot more little endian platforms than just the intel ones, aswell.

It seems you're totally unsuitable as a driver or subsystem maintainer if you favour you own employer so much.

author
#2 lore raw
Quoted 5 lines · Christoph Hellwig

There's a lot more little endian platforms than just the intel ones, aswell.

It seems you're totally unsuitable as a driver or subsystem maintainer if you favour you own employer so much.

I'm not saying I'm not going to support it in the future. But currently ipw2100 doesn't support big endian machines is the truth. One reason is because I don't have such a box with an ipw2100 card. If you or someone has such a platform and is willing to try patches for me, I'm happy to get this done. That's why the ipw2200 driver has the BE supported.

Thanks,
-yi

#3 lore raw
Quoted 5 lines · Zhu Yi

I'm not saying I'm not going to support it in the future. But currently ipw2100 doesn't support big endian machines is the truth. One reason is because I don't have such a box with an ipw2100 card. If you or someone has such a platform and is willing to try patches for me, I'm happy to get this done. That's why the ipw2200 driver has the BE supported.

I'm happy to test ipw2100 on big endian systems if you send me a card.