Skip to contentSkip to conversation

drm, minor fixes

PATCH Frederik Deweerdt 1 participant 1 message Aug 21, 2006

lore
Share & tools
lore
#0 lore raw

(Sorry, I forgot to CCs.)

Quoted 13 lines · Dave Airlie
Quoted 13 lines
Quoted 3 lines

are you sure the callers of these don't wrap it inside a DRM_ERR() macro ?

I changed the values when:
- I've checked what seemed right, getting back to the system call. drm_ioctl(), through a call to func().
That's the case for:
- the EFAULT value in i915_emit_box
- two EINVAL values in drm_setversion
- the return value wasn't used. That was the case for drm_set_busid return values, I felt having returned values negative from the start was more consistent.

Quoted 3 lines
Quoted 1 line

Is there a particular change that looked suspicious to you?

[...], however I doubt any of the codepaths are causing a major problem [...]

I agree, I just corrected those because I happen to stumble upon them. I've tried a kernel with those corrections alone, and it didn't changed anything on the oopses.

Regards,
Frederik